Skip to content

Integrate Metrics with Beholder#42

Merged
DylanTinianov merged 34 commits into
mainfrom
feature/integrate-txm-metrics-with-beholder
May 2, 2025
Merged

Integrate Metrics with Beholder#42
DylanTinianov merged 34 commits into
mainfrom
feature/integrate-txm-metrics-with-beholder

Conversation

@DylanTinianov
Copy link
Copy Markdown
Contributor

@DylanTinianov DylanTinianov commented Apr 28, 2025

Description

Integrated framework metrics for TXM, LogPoller, and MultiNode with Beholder, and centralized metrics into framework/metrics.

Includes Reporting of Node Client Versions through MultiNode

Expands on the following initial changes from @amit-momin:

  • Initialized beholder meters for existing Broadcaster and Confirmer prometheus metrics
  • Centralized metrics into a single struct
  • Passed new metric struct into Broadcaster and Confirmer
  • Added helper methods to increment or observe both beholder and prom metrics
  • Replaced direct calls to prom metrics with metric class helper methods
  • Added new metric to Broadcaster to count number of broadcasts

@DylanTinianov DylanTinianov self-assigned this Apr 28, 2025
@DylanTinianov DylanTinianov changed the title Integrame framework metrics with Beholder Integrate framework metrics with Beholder Apr 28, 2025
@DylanTinianov DylanTinianov changed the title Integrate framework metrics with Beholder Integrate Metrics with Beholder Apr 28, 2025
@DylanTinianov DylanTinianov changed the title Integrate Metrics with Beholder Integrate TXM, LP, MN Metrics with Beholder Apr 28, 2025
@DylanTinianov DylanTinianov changed the title Integrate TXM, LP, MN Metrics with Beholder Integrate Metrics with Beholder Apr 28, 2025
@DylanTinianov DylanTinianov marked this pull request as ready for review April 28, 2025 15:30
@DylanTinianov DylanTinianov requested a review from a team as a code owner April 28, 2025 15:30
Comment thread chains/txmgr/confirmer.go
Comment thread metrics/chain_families.go
Comment thread chains/txmgr/confirmer.go
Comment thread metrics/logpoller.go Outdated
Comment thread metrics/txm.go
Comment thread metrics/txm.go
Comment thread multinode/multi_node.go
Comment thread metrics/logpoller_test.go Outdated
@DylanTinianov DylanTinianov requested a review from amit-momin May 2, 2025 19:40
Comment thread multinode/node_fsm.go Outdated
amit-momin
amit-momin previously approved these changes May 2, 2025
Comment thread multinode/types.go Outdated
@DylanTinianov DylanTinianov merged commit 2df4841 into main May 2, 2025
20 of 21 checks passed
@DylanTinianov DylanTinianov deleted the feature/integrate-txm-metrics-with-beholder branch May 2, 2025 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants