Skip to content

adding error to wf-exec-finished proto#295

Merged
patrickhuie19 merged 2 commits intomainfrom
feat/wf-exec-output
Feb 17, 2026
Merged

adding error to wf-exec-finished proto#295
patrickhuie19 merged 2 commits intomainfrom
feat/wf-exec-output

Conversation

@patrickhuie19
Copy link
Copy Markdown
Contributor

@patrickhuie19 patrickhuie19 commented Feb 17, 2026

No description provided.

@wentzeld @patrickhuie19
Add error field to WorkflowExecutionFinished proto
6e4ecc6 
  Add string error = 6 to WorkflowExecutionFinished message, matching
  the existing pattern from CapabilityExecutionFinished. Regenerated
  Go bindings.
@patrickhuie19 patrickhuie19 requested review from a team as code owners February 17, 2026 04:06
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Feb 17, 2026 •
edited
Loading

⚠️ No Changeset found

Latest commit: 07556f7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 17, 2026

👋 patrickhuie19, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 17, 2026 •
edited
Loading

The latest Buf updates on your PR. Results from workflow Regenerate Protobuf Files / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed⏩ skippedFeb 17, 2026, 4:08 AM

@patrickhuie19
Copy link
Copy Markdown
Contributor Author

patrickhuie19 commented Feb 17, 2026

cc @wentzeld 🫡 who is now writing code! the future is here, just unevenly distributed

@patrickhuie19 patrickhuie19 merged commit 5cc9668 into main Feb 17, 2026
22 checks passed
@patrickhuie19 patrickhuie19 deleted the feat/wf-exec-output branch February 17, 2026 04:36
@patrickhuie19 patrickhuie19 mentioned this pull request Feb 17, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmank88 jmank88 jmank88 approved these changes

@ecPablo ecPablo Awaiting requested review from ecPablo

@krehermann krehermann Awaiting requested review from krehermann

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@patrickhuie19 @jmank88 @wentzeld