Add capability-development branch protection CI by amit-momin · Pull Request #327 · smartcontractkit/chainlink-protos

amit-momin · 2026-03-25T16:58:52Z

No description provided.

changeset-bot · 2026-03-25T16:58:57Z

⚠️ No Changeset found

Latest commit: d508e43

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2026-03-25T16:59:35Z

The latest Buf updates on your PR. Results from workflow Regenerate Protobuf Files / buf (pull_request).

Build	Format	Lint	Breaking	Updated (UTC)
`✅ passed`	`✅ passed`	`✅ passed`	`⏩ skipped`	Mar 26, 2026, 5:15 PM

chainchad · 2026-03-25T18:59:09Z

+        run: |
+          git fetch origin "${TARGET_BRANCH}" --quiet 2>/dev/null || true
+
+          CRE_CHANGED=$(git diff --name-only "origin/${TARGET_BRANCH}" -- cre/)


Suggested change

CRE_CHANGED=$(git diff --name-only "origin/${TARGET_BRANCH}" -- cre/)

CRE_CHANGED=$(git diff --name-only "origin/${TARGET_BRANCH}...HEAD" -- cre/)

A little more precise

chainchad · 2026-03-25T19:00:00Z

+permissions:
+  contents: read
+
+jobs:
+  check-cre-target-branch:
+    runs-on: ubuntu-latest
+    steps:


Suggested change

permissions:

contents: read

jobs:

check-cre-target-branch:

runs-on: ubuntu-latest

steps:

permissions: {}

jobs:

check-cre-target-branch:

permissions:

contents: read

runs-on: ubuntu-latest

steps:

It's better to scope perms to just the job and "blank out" default perms.

chainchad · 2026-03-25T19:00:46Z

+
+          CRE_CHANGED=$(git diff --name-only "origin/${TARGET_BRANCH}" -- cre/)
+
+          if [ -z "$CRE_CHANGED" ]; then


Suggested change

if [ -z "$CRE_CHANGED" ]; then

if [[ -z "$CRE_CHANGED" ]]; then

Nit, but with bash it's always safer to use [[ for test/conditionals.

chainchad · 2026-03-25T19:01:46Z

+          if [ "$TARGET_BRANCH" != "main" ]; then
+            echo "PR targets '${TARGET_BRANCH}', not 'main'. CRE changes are allowed."
+            exit 0
+          fi


Should you just filter on on.pull_request.branches: [main]?

chainchad

LGTM! I would change all [ to [[ for the remaining bash conditionals but can be done in a follow-up or future.

…tion-ci

* Add Pharos Atlantic support (#306) * Added Pharos Atlantic support * Auto-fix: buf format, gofmt, go generate, go mod tidy --------- Co-authored-by: app-token-issuer-engops[bot] <144731339+app-token-issuer-engops[bot]@users.noreply.github.com> * aptos proto: add ledger_version to ViewRequest (#310) * aptos proto: add ledger_version to ViewRequest * Auto-fix: buf format, gofmt, go generate, go mod tidy --------- Co-authored-by: app-token-issuer-engops[bot] <144731339+app-token-issuer-engops[bot]@users.noreply.github.com> * Add xlayer, megaeth, cronos, mantle, tac, unichain, scroll, sonic testnet support (#308) * Added xlayer megaeth cronos mantle tac unichain scroll sonic support * Auto-fix: buf format, gofmt, go generate, go mod tidy * Added celo sepolia * Auto-fix: buf format, gofmt, go generate, go mod tidy * Added gnosis chiado * Auto-fix: buf format, gofmt, go generate, go mod tidy * Removed celo sepolia * Auto-fix: buf format, gofmt, go generate, go mod tidy * Removed gnosis chiado * Auto-fix: buf format, gofmt, go generate, go mod tidy --------- Co-authored-by: app-token-issuer-engops[bot] <144731339+app-token-issuer-engops[bot]@users.noreply.github.com> * Add andesite chain (#313) * Added andesite chain * Auto-fix: buf format, gofmt, go generate, go mod tidy --------- Co-authored-by: app-token-issuer-engops[bot] <144731339+app-token-issuer-engops[bot]@users.noreply.github.com> * Add new mainnet chains to client proto (#315) * Added new mainnet chains to client proto * Auto-fix: buf format, gofmt, go generate, go mod tidy --------- Co-authored-by: app-token-issuer-engops[bot] <144731339+app-token-issuer-engops[bot]@users.noreply.github.com> * Remove aptos (moved to capabilities-development branch) (#316) * remove aptos * Auto-fix: buf format, gofmt, go generate, go mod tidy --------- Co-authored-by: app-token-issuer-engops[bot] <144731339+app-token-issuer-engops[bot]@users.noreply.github.com> * Add owner and execution_id to WorkflowExecution proto (#317) Adds workflow-level context to the app-specific proto rather than the generic ComputeRequest type, per vreff's feedback on CC PR #277. The enclave app reads these from the deserialized WorkflowExecution for runtime secret fetching from VaultDON via the relay DON. * Add Privacy as codeowners of protos embedded gen files (#318) * feat: add NodeBuildInfo proto and register it in chip schemas (#320) * Revert "Remove aptos (moved to capabilities-development branch) (#316)" (#321) This reverts commit 1124ff8. * Add hyperliquid mainnet to client proto (#322) * Added hyperliquid mainnet to client proto * Auto-fix: buf format, gofmt, go generate, go mod tidy --------- Co-authored-by: app-token-issuer-engops[bot] <144731339+app-token-issuer-engops[bot]@users.noreply.github.com> * Add gnosis chiado to client proto (#324) * Added gnosis chiado to client proto * Auto-fix: buf format, gofmt, go generate, go mod tidy --------- Co-authored-by: app-token-issuer-engops[bot] <144731339+app-token-issuer-engops[bot]@users.noreply.github.com> * add WorkflowUserMetric (#319) * add WorkflowUserMetric * fix metric suffix * bot: regenerate protobuf files * add USER_METRIC_TYPE_UNSPECIFIED * bot: regenerate protobuf files * update WorkflowUserMetric value to double * drop histogram support * bot: regenerate protobuf files --------- Co-authored-by: app-token-issuer-engops[bot] <144731339+app-token-issuer-engops[bot]@users.noreply.github.com> * Revert "Revert "Remove aptos (moved to capabilities-development branch) (#316…" (#331) This reverts commit ad04ed6. * Add capability-development branch protection CI (#327) * Add capability-development branch protection ci * Upgraded checkout action to major version tag * Updated validation to only occur when target branch is main * Addressed feedback * beholder: publish workflows/v2/workflow_user_metric (#333) * beholder: publish workflows/v2/workflow_user_metric.proto * remove entry from deprecated files * cre-1835: steady and transition indicators (#334) --------- Co-authored-by: amit-momin <108959691+amit-momin@users.noreply.github.com> Co-authored-by: app-token-issuer-engops[bot] <144731339+app-token-issuer-engops[bot]@users.noreply.github.com> Co-authored-by: cawthorne <cawthornegd@gmail.com> Co-authored-by: Tejaswi Nadahalli <tejaswi.nadahalli@smartcontract.com> Co-authored-by: vreff <104409744+vreff@users.noreply.github.com> Co-authored-by: Gheorghe Strimtu <studentcuza@gmail.com> Co-authored-by: karen-stepanyan <91897037+karen-stepanyan@users.noreply.github.com> Co-authored-by: mchain0 <maciej.wisniewski@smartcontract.com>

Add capability-development branch protection ci

4396356

amit-momin changed the base branch from main to capabilities-development March 25, 2026 17:03

app-token-issuer-engops Bot temporarily deployed to publish March 25, 2026 17:03 Inactive

amit-momin changed the base branch from capabilities-development to main March 25, 2026 17:10

amit-momin force-pushed the cre/add-capability-development-branch-protection-ci branch from 359eb9d to 4396356 Compare March 25, 2026 17:14

Upgraded checkout action to major version tag

64301fe

amit-momin force-pushed the cre/add-capability-development-branch-protection-ci branch 4 times, most recently from 377d01d to 64301fe Compare March 25, 2026 18:48

amit-momin marked this pull request as ready for review March 25, 2026 18:48

amit-momin requested review from a team as code owners March 25, 2026 18:48

product-security-plaid-production Bot requested review from ChrisAmora and DylanTinianov March 25, 2026 18:49

amit-momin changed the title ~~Add capability-development branch protection ci~~ Add capability-development branch protection CI Mar 25, 2026

Updated validation to only occur when target branch is main

3f6b3c2

chainchad reviewed Mar 25, 2026

View reviewed changes

Addressed feedback

a72b2e4

amit-momin force-pushed the cre/add-capability-development-branch-protection-ci branch 3 times, most recently from 721414a to a72b2e4 Compare March 25, 2026 19:18

chainchad approved these changes Mar 25, 2026

View reviewed changes

ilija42 approved these changes Mar 26, 2026

View reviewed changes

cedric-cordenier approved these changes Mar 26, 2026

View reviewed changes

amit-momin enabled auto-merge (squash) March 26, 2026 17:15

Merge branch 'main' into cre/add-capability-development-branch-protec…

d508e43

…tion-ci

amit-momin merged commit 93f52c3 into main Mar 26, 2026
22 checks passed

amit-momin deleted the cre/add-capability-development-branch-protection-ci branch March 26, 2026 17:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add capability-development branch protection CI#327

Add capability-development branch protection CI#327
amit-momin merged 5 commits intomainfrom
cre/add-capability-development-branch-protection-ci

amit-momin commented Mar 25, 2026

Uh oh!

changeset-bot Bot commented Mar 25, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Mar 25, 2026 •

edited

Loading

Uh oh!

Uh oh!

chainchad Mar 25, 2026

Uh oh!

chainchad Mar 25, 2026

Uh oh!

chainchad Mar 25, 2026

Uh oh!

chainchad Mar 25, 2026

Uh oh!

chainchad left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	CRE_CHANGED=$(git diff --name-only "origin/${TARGET_BRANCH}" -- cre/)
	CRE_CHANGED=$(git diff --name-only "origin/${TARGET_BRANCH}...HEAD" -- cre/)


		CRE_CHANGED=$(git diff --name-only "origin/${TARGET_BRANCH}" -- cre/)

		if [ -z "$CRE_CHANGED" ]; then

	if [ -z "$CRE_CHANGED" ]; then
	if [[ -z "$CRE_CHANGED" ]]; then

Conversation

amit-momin commented Mar 25, 2026

Uh oh!

changeset-bot Bot commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

github-actions Bot commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

chainchad Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

chainchad Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

chainchad Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

chainchad Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

chainchad left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

changeset-bot Bot commented Mar 25, 2026 •

edited

Loading

github-actions Bot commented Mar 25, 2026 •

edited

Loading