Skip to content

codec: use common query serialization funcs to drop aptos/codec dep #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FelixFan1992 merged 1 commit into from
Jul 14, 2026
+4 −51
Merged

codec: use common query serialization funcs to drop aptos/codec dep #457

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions codec/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,25 +6,16 @@ require (
github.com/aptos-labs/aptos-go-sdk v1.13.0
github.com/block-vision/sui-go-sdk v1.2.1
github.com/mitchellh/mapstructure v1.5.1-0.20220423185008-bf980b35cac4
github.com/smartcontractkit/chainlink-aptos/codec v0.0.0-20260708114855-e953eeb028a7
github.com/smartcontractkit/chainlink-common v0.11.2-0.20260713194119-2689c5708c8b
github.com/smartcontractkit/chainlink-common v0.11.2-0.20260714095740-4b29a5655cd2
github.com/stretchr/testify v1.11.1
)

require (
filippo.io/edwards25519 v1.1.1 // indirect
github.com/cespare/xxhash/v2 v2.3.0 // indirect
github.com/coder/websocket v1.8.14 // indirect
github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc // indirect
github.com/decred/dcrd/dcrec/secp256k1/v4 v4.4.0 // indirect
github.com/ethereum/go-ethereum v1.17.4 // indirect
github.com/go-logr/logr v1.4.3 // indirect
github.com/go-logr/stdr v1.2.2 // indirect
github.com/go-viper/mapstructure/v2 v2.5.0 // indirect
github.com/google/uuid v1.6.0 // indirect
github.com/hasura/go-graphql-client v0.15.1 // indirect
github.com/hdevalence/ed25519consensus v0.2.0 // indirect
github.com/holiman/uint256 v1.3.2 // indirect
github.com/mr-tron/base58 v1.2.0 // indirect
github.com/pelletier/go-toml/v2 v2.3.0 // indirect
github.com/pkg/errors v0.9.1 // indirect
Expand Down
40 changes: 2 additions & 38 deletions codec/go.sum
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 1 addition & 3 deletions codec/loop/loop_reader.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@ import (
"github.com/smartcontractkit/chainlink-common/pkg/types/query"
"github.com/smartcontractkit/chainlink-common/pkg/types/query/primitives"

"github.com/smartcontractkit/chainlink-aptos/codec/loop"

"github.com/smartcontractkit/chainlink-sui/codec"
)

Expand Down Expand Up @@ -127,7 +125,7 @@ func (s *loopChainReader) BatchGetLatestValues(ctx context.Context, request type
}

func (s *loopChainReader) QueryKey(ctx context.Context, contract types.BoundContract, filter query.KeyFilter, limitAndSort query.LimitAndSort, sequenceDataType any) ([]types.Sequence, error) {
convertedExpressions, err := loop.SerializeExpressions(filter.Expressions)
convertedExpressions, err := query.SerializeExpressions(filter.Expressions)
if err != nil {
return nil, fmt.Errorf("failed to serialize QueryKey expressions: %w", err)
}
Expand Down
Loading