keystore: Fix aptoskey public key encoding

archseer · archseer · commit 116757b0df62 · 2024-07-17T12:06:05.000+09:00
diff --git a/core/services/keystore/keys/aptoskey/key.go b/core/services/keystore/keys/aptoskey/key.go
@@ -6,8 +6,6 @@ import (
 	crypto_rand "crypto/rand"
 	"fmt"
 	"io"
-
-	"github.com/mr-tron/base58"
 )
 
 // Raw represents the Aptos private key
@@ -77,9 +75,10 @@ func (key Key) GetPublic() ed25519.PublicKey {
 	return key.pubKey
 }
 
-// PublicKeyStr return base58 encoded public key
+// PublicKeyStr returns hex encoded public key
+// https://github.com/aptos-foundation/AIPs/blob/main/aips/aip-40.md#long
 func (key Key) PublicKeyStr() string {
-	return base58.Encode(key.pubKey)
+	return fmt.Sprintf("0x%064x", key.pubKey)
 }
 
 // Raw returns the seed from private key

Original file line number	Diff line number	Diff line change
`@@ -6,8 +6,6 @@ import (`
`6`	`6`	`crypto_rand "crypto/rand"`
`7`	`7`	`"fmt"`
`8`	`8`	`"io"`
`9`		`-`
`10`		`- "github.com/mr-tron/base58"`
`11`	`9`	`)`
`12`	`10`
`13`	`11`	`// Raw represents the Aptos private key`
`@@ -77,9 +75,10 @@ func (key Key) GetPublic() ed25519.PublicKey {`
`77`	`75`	`return key.pubKey`
`78`	`76`	`}`
`79`	`77`
`80`		`-// PublicKeyStr return base58 encoded public key`
	`78`	`+// PublicKeyStr returns hex encoded public key`
	`79`	`+// https://github.com/aptos-foundation/AIPs/blob/main/aips/aip-40.md#long`
`81`	`80`	`func (key Key) PublicKeyStr() string {`
`82`		`- return base58.Encode(key.pubKey)`
	`81`	`+ return fmt.Sprintf("0x%064x", key.pubKey)`
`83`	`82`	`}`
`84`	`83`
`85`	`84`	`// Raw returns the seed from private key`