Skip to content

Commit 1ea60a7

Browse files
sebawoclaude
andcommitted
fix: remove unnecessary Solana Docker setup from empty-config flaky test [CCIP-10960]
TestSetTokenTransferFeeConfig_EmptyConfigIsGracefullyHandled was initialising a full Solana test environment (Docker validator container + network download of .so program artifacts) that it never used. The changeset early-exits when InputsByChain is empty, so no chain interaction ever occurs. The Docker/network setup was the sole source of non-determinism. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 29b3d15 commit 1ea60a7

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

deployment/ccip/changeset/crossfamily/cs_set_token_transfer_fee_config_test.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -282,10 +282,11 @@ func TestSetTokenTransferFeeConfig_Validations(t *testing.T) {
282282
}
283283

284284
func TestSetTokenTransferFeeConfig_EmptyConfigIsGracefullyHandled(t *testing.T) {
285+
// No Solana chains needed: empty InputsByChain early-exits before any chain interaction.
286+
// Including WithSolChains would spin up a Docker container + download .so artifacts,
287+
// introducing network and Docker flakiness for a path that never touches those chains.
285288
env, _ := testhelpers.NewMemoryEnvironment(t,
286-
testhelpers.WithCCIPSolanaContractVersion(ccip_cs_sol_v0_1_1.SolanaContractV0_1_1),
287289
testhelpers.WithNumOfChains(2),
288-
testhelpers.WithSolChains(1),
289290
)
290291

291292
_, err := commonchangeset.Apply(t, env.Env,

0 commit comments

Comments
 (0)