lint fixes (#21569)

Author: jmank88

.golangci.yml

@@ -1,6 +1,10 @@
 version: "2"
 run:
   allow-parallel-runners: true
+  build-tags:
+    - integration
+    - dev
+    - trace
 linters:
   enable:
     - containedctx

core/capabilities/ccip/ccipevm/pluginconfig.go

@@ -11,8 +11,6 @@ import (
 	"github.com/smartcontractkit/chainlink/v2/core/capabilities/ccip/ocrimpls"
 )
 
-const defaultCommitGasLimit = 500_000
-
 // InitializePluginConfig returns a PluginConfig for EVM chains.
 func InitializePluginConfig(lggr logger.Logger, extraDataCodec ccipocr3.ExtraDataCodecBundle) ccipcommon.PluginConfig {
 	return ccipcommon.PluginConfig{

core/capabilities/remote/executable/hasher.go

@@ -132,7 +132,6 @@ func (r *writeReportExcludeSignaturesHasher) Hash(msg *types.MessageBody) ([32]b
 		}
 	default:
 		return [32]byte{}, fmt.Errorf("unexpected report family: %s", family)
-
 	}
 
 	req.Payload = payload

core/cmd/solana_transaction_commands_test.go

@@ -64,7 +64,7 @@ func TestShell_SolanaSendSol(t *testing.T) {
 		{amount: "0", expErr: "amount must be greater than zero"},
 		{amount: "asdf", expErr: "invalid amount:"},
 	} {
-		tt := tt
+
 		t.Run(tt.amount, func(t *testing.T) {
 			startBal, err := balance(from.PublicKey(), url)
 			require.NoError(t, err)
@@ -86,7 +86,7 @@ func TestShell_SolanaSendSol(t *testing.T) {
 			}
 
 			// Check CLI output
-			require.Greater(t, len(r.Renders), 0)
+			require.NotEmpty(t, r.Renders)
 			renderer := r.Renders[len(r.Renders)-1]
 			renderedMsg := renderer.(*cmd.SolanaMsgPresenter)
 			t.Logf("%+v\n", renderedMsg)

core/scripts/cre/environment/examples/workflows/v2/proof-of-reserve/cron-based/types/types.go

@@ -1,4 +1,4 @@
-package types
+package types //nolint:revive // meaningless name already referenced
 
 import (
 	"github.com/ethereum/go-ethereum/common"

core/services/chainlink/config_general_dev_test.go

@@ -7,8 +7,6 @@ import (
 
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
-
-	"github.com/smartcontractkit/chainlink/v2/core/logger"
 )
 
 // Tests in this file only run in dev mode
@@ -18,7 +16,7 @@ func TestTOMLGeneralConfig_DevModeInsecureConfig(t *testing.T) {
 	t.Parallel()
 
 	t.Run("all insecure configs are false by default", func(t *testing.T) {
-		config, err := GeneralConfigOpts{}.New(logger.TestLogger(t))
+		config, err := GeneralConfigOpts{}.New()
 		require.NoError(t, err)
 
 		assert.False(t, config.Insecure().DevWebServer())
@@ -34,24 +32,26 @@ func TestTOMLGeneralConfig_DevModeInsecureConfig(t *testing.T) {
 				*c.Insecure.DisableRateLimiting = true
 				*c.Insecure.InfiniteDepthQueries = true
 				*c.Insecure.OCRDevelopmentMode = true
-			}}.New(logger.TestLogger(t))
+			}}.New()
 		require.NoError(t, err)
 
 		assert.True(t, config.Insecure().DevWebServer())
 		assert.True(t, config.Insecure().DisableRateLimiting())
 		assert.True(t, config.Insecure().InfiniteDepthQueries())
-		assert.True(t, config.OCRDevelopmentMode())
+		assert.True(t, config.Insecure().OCRDevelopmentMode())
 	})
 
 	t.Run("ParseConfig accepts insecure values on dev builds", func(t *testing.T) {
-		opts := GeneralConfigOpts{}
-		err := opts.ParseConfig(`
-		  [insecure]
-		  DevWebServer = true
-		`)
-		cfg, err := opts.init()
+		opts := GeneralConfigOpts{
+			ConfigStrings: []string{`
+[insecure]
+DevWebServer = true
+`,
+			},
+		}
+		cfg, err := opts.New()
 		require.NoError(t, err)
-		err = cfg.c.Validate()
+		err = cfg.Validate()
 		require.NoError(t, err)
 	})
 }

core/services/gateway/handlers/capabilities/handler_test.go

@@ -31,18 +31,6 @@ import (
 	"github.com/smartcontractkit/chainlink/v2/core/services/gateway/network/mocks"
 )
 
-const (
-	defaultSendChannelBufferSize = 1000
-	privateKey1                  = "65456ffb8af4a2b93959256a8e04f6f2fe0943579fb3c9c3350593aabb89023f"
-	privateKey2                  = "65456ffb8af4a2b93959256a8e04f6f2fe0943579fb3c9c3350593aabb89023e"
-	triggerID1                   = "5"
-	triggerID2                   = "6"
-	workflowID1                  = "15c631d295ef5e32deb99a10ee6804bc4af13855687559d7ff6552ac6dbb2ce0"
-	workflowExecutionID1         = "95ef5e32deb99a10ee6804bc4af13855687559d7ff6552ac6dbb2ce0abbadeed"
-	owner1                       = "0x00000000000000000000000000000000000000aa"
-	address1                     = "0x853d51d5d9935964267a5050aC53aa63ECA39bc5"
-)
-
 func setupHandler(t *testing.T) (*handler, *mocks.HTTPClient, *handlermocks.DON, []gwcommon.TestNode) {
 	lggr := logger.Test(t)
 	httpClient := mocks.NewHTTPClient(t)

core/services/gateway/handlers/vault/handler.go

@@ -646,27 +646,6 @@ func (h *handler) handleSecretsDelete(ctx context.Context, ar *activeRequest) er
 	return h.fanOutToVaultNodes(ctx, l, ar)
 }
 
-func (h *handler) handleSecretsGet(ctx context.Context, ar *activeRequest) error {
-	l := logger.With(h.lggr, "method", ar.req.Method, "requestID", ar.req.ID)
-
-	secretsGetRequest := &vaultcommon.GetSecretsRequest{}
-	if err := json.Unmarshal(*ar.req.Params, &secretsGetRequest); err != nil {
-		return h.sendResponse(ctx, ar, h.errorResponse(ar.req, api.UserMessageParseError, err, nil))
-	}
-	for _, getRequest := range secretsGetRequest.Requests {
-		if getRequest.Id != nil && getRequest.Id.Namespace == "" {
-			getRequest.Id.Namespace = vaulttypes.DefaultNamespace
-		}
-	}
-	err := h.ValidateGetSecretsRequest(secretsGetRequest)
-	if err != nil {
-		l.Warnw("failed to validate get secrets request", "error", err)
-		return h.sendResponse(ctx, ar, h.errorResponse(ar.req, api.InvalidParamsError, fmt.Errorf("failed to validate get secrets request: %w", err), nil))
-	}
-
-	return h.fanOutToVaultNodes(ctx, l, ar)
-}
-
 func (h *handler) handleSecretsList(ctx context.Context, ar *activeRequest) error {
 	l := logger.With(h.lggr, "method", ar.req.Method, "requestID", ar.req.ID)
 

core/services/llo/channeldefinitions/onchain_channel_definition_cache.go

@@ -184,7 +184,6 @@ type HTTPClient interface {
 // sets up the initial state, and applies any provided options. The cache must be started via Start()
 // before it begins polling and fetching definitions.
 func NewChannelDefinitionCache(lggr logger.Logger, orm ChannelDefinitionCacheORM, client HTTPClient, lp logpoller.LogPoller, addr common.Address, donID uint32, fromBlock int64, options ...Option) llotypes.ChannelDefinitionCache {
-
 	cdc := &channelDefinitionCache{
 		orm:             orm,
 		client:          client,

core/services/llo/observation/data_source.go

@@ -137,7 +137,6 @@ func (d *dataSource) Observe(ctx context.Context, streamValues llo.StreamValues,
 // Based on the expected maxObservationDuration determine the pace of the observation loop
 // and for how long to cache the observations.
 func (d *dataSource) startObservationLoop(loopStartedCh chan struct{}) {
-
 	// atomically set the observation loop started flag to true
 	// or return if it's already started
 	if !d.observationLoopStarted.CompareAndSwap(false, true) {