[CRE] Fix pinned version TODO

Author: bolekk

core/services/workflows/v2/engine.go

@@ -455,16 +455,13 @@ func (e *Engine) runTriggerSubscriptionPhase(ctx context.Context) error {
 			registrationID := TriggerRegistrationID(e.cfg.WorkflowID, i)
 			e.logger().Debugw("Registering trigger", "triggerID", sub.Id, "method", sub.Method)
 			metadata := capabilities.RequestMetadata{
-				WorkflowID:          e.cfg.WorkflowID,
-				WorkflowOwner:       e.cfg.WorkflowOwner,
-				WorkflowName:        e.cfg.WorkflowName.Hex(),
-				WorkflowTag:         e.cfg.WorkflowTag,
-				DecodedWorkflowName: e.cfg.WorkflowName.String(),
-				WorkflowDonID:       e.localNode.Load().WorkflowDON.ID,
-				// TODO(CRE-1636): This should be pinnedWorkflowDonConfigVersion, but it causes CI timeouts
-				// that I can't reproduce locally. This values is unused in trigger subscription phase
-				// so it's not a problem. Still, let's do it right when CI is fixed.
-				WorkflowDonConfigVersion:      e.localNode.Load().WorkflowDON.ConfigVersion,
+				WorkflowID:                    e.cfg.WorkflowID,
+				WorkflowOwner:                 e.cfg.WorkflowOwner,
+				WorkflowName:                  e.cfg.WorkflowName.Hex(),
+				WorkflowTag:                   e.cfg.WorkflowTag,
+				DecodedWorkflowName:           e.cfg.WorkflowName.String(),
+				WorkflowDonID:                 e.localNode.Load().WorkflowDON.ID,
+				WorkflowDonConfigVersion:      pinnedWorkflowDonConfigVersion,
 				ReferenceID:                   fmt.Sprintf("trigger_%d", i),
 				WorkflowRegistryChainSelector: e.cfg.WorkflowRegistryChainSelector,
 				WorkflowRegistryAddress:       e.cfg.WorkflowRegistryAddress,

core/services/workflows/v2/engine_test.go

@@ -607,7 +607,7 @@ func TestEngine_Execution(t *testing.T) {
 		require.Equal(t, cfg.WorkflowName.Hex(), capturedTriggerRequest.Metadata.WorkflowName)
 		require.Equal(t, cfg.WorkflowTag, capturedTriggerRequest.Metadata.WorkflowTag)
 		require.Equal(t, uint32(0), capturedTriggerRequest.Metadata.WorkflowDonID)
-		require.Equal(t, uint32(0), capturedTriggerRequest.Metadata.WorkflowDonConfigVersion)
+		require.Equal(t, uint32(1), capturedTriggerRequest.Metadata.WorkflowDonConfigVersion)
 		require.Equal(t, "trigger_0", capturedTriggerRequest.Metadata.ReferenceID)
 		require.Equal(t, "method", capturedTriggerRequest.Method)
 		require.Nil(t, capturedTriggerRequest.Payload)