Revert file fetcher HTTP URL handling

The filepath.Base() code for HTTP URLs in newFileFetcher was dead code.
No test or production path sends an HTTP URL to a file-based fetcher.
The enclave fetches binaries via its own BinaryFetcher, independent of
the node syncer's fetcher.

Author: nadahalli

core/services/workflows/syncer/fetcher.go

@@ -178,19 +178,12 @@ func newFileFetcher(basePath string, lggr logger.Logger) types.FetcherFunc {
 			return nil, fmt.Errorf("invalid URL: %w", err)
 		}
 
-		var fullPath string
-		if u.Scheme == "http" || u.Scheme == "https" {
-			// For HTTP(S) URLs, extract just the filename and resolve against basePath.
-			// This supports confidential workflows where the on-chain URL must be HTTP
-			// (so the enclave can fetch the binary), but the syncer reads from the local filesystem.
-			fullPath = filepath.Join(basePath, filepath.Base(u.Path))
-		} else {
-			fullPath = filepath.Clean(u.Path)
-			// ensure that the incoming request URL is either relative or absolute but within the basePath
-			if !filepath.IsAbs(fullPath) {
-				// If it's not absolute, we assume it's relative to the basePath
-				fullPath = filepath.Join(basePath, fullPath)
-			}
+		fullPath := filepath.Clean(u.Path)
+
+		// ensure that the incoming request URL is either relative or absolute but within the basePath
+		if !filepath.IsAbs(fullPath) {
+			// If it's not absolute, we assume it's relative to the basePath
+			fullPath = filepath.Join(basePath, fullPath)
 		}
 		if !strings.HasPrefix(fullPath, basePath) {
 			return nil, fmt.Errorf("request URL %s is not within the basePath %s", fullPath, basePath)

core/services/workflows/syncer/v2/fetcher.go

@@ -212,19 +212,12 @@ func newFileFetcher(basePath string, lggr logger.Logger) types.FetcherFunc {
 			return nil, fmt.Errorf("invalid URL: %w", err)
 		}
 
-		var fullPath string
-		if u.Scheme == "http" || u.Scheme == "https" {
-			// For HTTP(S) URLs, extract just the filename and resolve against basePath.
-			// This supports confidential workflows where the on-chain URL must be HTTP
-			// (so the enclave can fetch the binary), but the syncer reads from the local filesystem.
-			fullPath = filepath.Join(basePath, filepath.Base(u.Path))
-		} else {
-			fullPath = filepath.Clean(u.Path)
-			// ensure that the incoming request URL is either relative or absolute but within the basePath
-			if !filepath.IsAbs(fullPath) {
-				// If it's not absolute, we assume it's relative to the basePath
-				fullPath = filepath.Join(basePath, fullPath)
-			}
+		fullPath := filepath.Clean(u.Path)
+
+		// ensure that the incoming request URL is either relative or absolute but within the basePath
+		if !filepath.IsAbs(fullPath) {
+			// If it's not absolute, we assume it's relative to the basePath
+			fullPath = filepath.Join(basePath, fullPath)
 		}
 		if !strings.HasPrefix(fullPath, basePath) {
 			return nil, fmt.Errorf("request URL %s is not within the basePath %s", fullPath, basePath)