Add option to disable hack in tests (to not pollute the test results)

Author: cll-gg

core/capabilities/integration_tests/keystone/securemint_workflow_test.go

@@ -21,7 +21,12 @@ import (
 )
 
 // Test_runSecureMintWorkflow can be run with:
+<<<<<<< HEAD
 // `CL_DATABASE_URL=postgresql://chainlink_dev:insecurepassword@localhost:5432/chainlink_development_test?sslmode=disable go test -timeout 2m -run ^Test_runSecureMintWorkflow$ github.com/smartcontractkit/chainlink/v2/core/capabilities/integration_tests/keystone -v 2>&1 | tee all.log | awk '/DEBUG|INFO|WARN|ERROR/ { print > "node_logs.log"; next }; { print > "other.log" }'; tail all.log`
+||||||| parent of b38bd132e7 (Add option to disable hack in tests (to not pollute the test results))
+=======
+// `SECURE_TRANSMITTER_HACK_DISABLED=true CL_DATABASE_URL=postgresql://chainlink_dev:insecurepassword@localhost:5432/chainlink_development_test?sslmode=disable go test -timeout 2m -run ^Test_runSecureMintWorkflow$ github.com/smartcontractkit/chainlink/v2/core/capabilities/integration_tests/keystone`
+>>>>>>> b38bd132e7 (Add option to disable hack in tests (to not pollute the test results))
 func Test_runSecureMintWorkflow(t *testing.T) {
 	ctx := t.Context()
 	lggr := logger.Test(t)

core/services/chainlink/application.go

@@ -8,6 +8,7 @@ import (
 	"io"
 	"math/big"
 	"net/http"
+	"os"
 	"strconv"
 	"sync"
 	"time"
@@ -72,7 +73,7 @@ import (
 	"github.com/smartcontractkit/chainlink/v2/core/services/nodestatusreporter/bridgestatus"
 	"github.com/smartcontractkit/chainlink/v2/core/services/ocr"
 	"github.com/smartcontractkit/chainlink/v2/core/services/ocr2"
-	securemint "github.com/smartcontractkit/chainlink/v2/core/services/ocr3/securemint"
+	"github.com/smartcontractkit/chainlink/v2/core/services/ocr3/securemint"
 	"github.com/smartcontractkit/chainlink/v2/core/services/ocrbootstrap"
 	"github.com/smartcontractkit/chainlink/v2/core/services/ocrcommon"
 	p2ptypes "github.com/smartcontractkit/chainlink/v2/core/services/p2p/types"
@@ -1116,22 +1117,28 @@ func newCREServices(
 		opts.CapabilitiesRegistry.SetLocalRegistry(&capabilities.TestMetadataRegistry{})
 	}
 
-	globalLogger.Infow("HACK: initializing Secure Mint transmitter for sending mock secure mint trigger events")
-	transmitterConfig := securemint.TransmitterConfig{
-		Logger:                       globalLogger,
-		CapabilitiesRegistry:         opts.CapabilitiesRegistry,
-		DonID:                        1,
-		TriggerCapabilityName:        "securemint-trigger",
-		TriggerCapabilityVersion:     "1.0.0",
-		TriggerTickerMinResolutionMs: 1000,
-		TriggerSendChannelBufferSize: 1000,
-	}
-	transmitter, err := transmitterConfig.NewTransmitter("securemint-transmitter")
-	if err != nil {
-		globalLogger.Errorw("could not create Secure Mint transmitter, skipping", "error", err)
+	// enable hack unless it's specifically disabled on the environment (e.g. for tests)
+	secureMintTransmitterHackDisabled, ok := os.LookupEnv("SECURE_TRANSMITTER_HACK_DISABLED")
+	if !ok || secureMintTransmitterHackDisabled != "true" {
+		globalLogger.Infow("HACK: initializing Secure Mint transmitter for sending mock secure mint trigger events")
+		transmitterConfig := securemint.TransmitterConfig{
+			Logger:                       globalLogger,
+			CapabilitiesRegistry:         opts.CapabilitiesRegistry,
+			DonID:                        1,
+			TriggerCapabilityName:        "securemint-trigger",
+			TriggerCapabilityVersion:     "1.0.0",
+			TriggerTickerMinResolutionMs: 1000,
+			TriggerSendChannelBufferSize: 1000,
+		}
+		transmitter, err := transmitterConfig.NewTransmitter("securemint-transmitter")
+		if err != nil {
+			globalLogger.Errorw("could not create Secure Mint transmitter, skipping", "error", err)
+		} else {
+			srvcs = append(srvcs, transmitter)
+			globalLogger.Infow("HACK: successfully created Secure Mint transmitter")
+		}
 	} else {
-		srvcs = append(srvcs, transmitter)
-		globalLogger.Infow("HACK: successfully created Secure Mint transmitter")
+		globalLogger.Infow("HACK: Secure Mint transmitter hack disabled, skipping")
 	}
 
 	return &CREServices{