cre-3245: prevent panic on empty observation while tearing down (#21878)

mchain0 · web-flow · commit a7be9295dd9a · 2026-04-07T10:54:48.000Z
diff --git a/core/services/ring/plugin.go b/core/services/ring/plugin.go
@@ -172,6 +172,9 @@ func (p *Plugin) getHealthyShards(shardHealth map[uint32]int) []uint32 {
 }
 
 func (p *Plugin) Outcome(_ context.Context, outctx ocr3types.OutcomeContext, _ types.Query, aos []types.AttributedObservation) (ocr3types.Outcome, error) {
+	if len(aos) == 0 {
+		return nil, errors.New("RingOCR Outcome: no attributed observations")
+	}
 	currentShardHealth, allWorkflows, nows, wantShardVotes := p.collectShardInfo(aos)
 	p.lggr.Infow("RingOCR Outcome collect shard info", "currentShardHealth", currentShardHealth, "wantShardVotes", wantShardVotes)
 

Original file line number	Diff line number	Diff line change
`@@ -172,6 +172,9 @@ func (p *Plugin) getHealthyShards(shardHealth map[uint32]int) []uint32 {`
`172`	`172`	`}`
`173`	`173`
`174`	`174`	`func (p *Plugin) Outcome(_ context.Context, outctx ocr3types.OutcomeContext, _ types.Query, aos []types.AttributedObservation) (ocr3types.Outcome, error) {`
	`175`	`+ if len(aos) == 0 {`
	`176`	`+ return nil, errors.New("RingOCR Outcome: no attributed observations")`
	`177`	`+ }`
`175`	`178`	`currentShardHealth, allWorkflows, nows, wantShardVotes := p.collectShardInfo(aos)`
`176`	`179`	`p.lggr.Infow("RingOCR Outcome collect shard info", "currentShardHealth", currentShardHealth, "wantShardVotes", wantShardVotes)`
`177`	`180`