use a different role for nightly

Author: Tofel

.github/workflows/system-tests-nightly.yml

@@ -104,6 +104,9 @@ jobs:
       pull-requests: write
     runs-on: ${{ matrix.runner }}
     if: needs.resolve-chainlink-image.result == 'success'
+    environment:
+      name: "integration"
+      deployment: false
     strategy:
       fail-fast: false
       matrix:
@@ -314,66 +317,52 @@ jobs:
             tests_dir: "logpoller"
             logs_archive_name: "logpoller-finality-tag"
     steps:
-      - name: Check if job should run
-        id: gate
-        working-directory: .
-        run: |
-          if [[ "${{ github.event_name }}" == "pull_request" && "${{ matrix.run_on_pr }}" == "false" ]]; then
-            echo "should_run=false" >> "$GITHUB_OUTPUT"
-            echo "Skipping ${{ matrix.display_name }} on PR"
-          else
-            echo "should_run=true" >> "$GITHUB_OUTPUT"
-          fi
-
       - name: Checkout code
-        if: steps.gate.outputs.should_run == 'true'
         uses: actions/checkout@v6
         with:
           ref: ${{ inputs.chainlink_version }}
           fetch-depth: 0
 
       - name: Set up Docker Buildx
-        if: steps.gate.outputs.should_run == 'true'
         uses: docker/setup-buildx-action@4d04d5d9486b7bd6fa91e7baf45bbb4f8b9deedd # v4.0.0
 
       - name: Install Just
-        if: steps.gate.outputs.should_run == 'true'
         uses: extractions/setup-just@e33e0265a09d6d736e2ee1e0eb685ef1de4669ff # v3
         with:
           just-version: "1.40.0"
 
-      - name: Configure AWS credentials using OIDC
-        if: steps.gate.outputs.should_run == 'true'
-        uses: aws-actions/configure-aws-credentials@8df5847569e6427dd6c4fb1cf565c83acfa8afa7 # v6.0.0
+      - name: Configure AWS Credentials
+        uses: aws-actions/configure-aws-credentials@010d0da01d0b5a38af31e9c3470dbfdabdecca3a # v4.0.1
         with:
-          role-to-assume: ${{ secrets.AWS_OIDC_IAM_ROLE_SDLC_ECR_READONLY_ARN }}
-          aws-region: us-west-2
+          aws-region: ${{ secrets.QA_AWS_REGION }}
+          role-to-assume: ${{ secrets.AWS_CTF_READ_ACCESS_ROLE_ARN }}
+          role-duration-seconds: 1800
+          mask-aws-account-id: true
 
-      - name: Authenticate to ECR
-        if: steps.gate.outputs.should_run == 'true'
+      - name: Login to Amazon ECR
         id: login-ecr
         uses: aws-actions/amazon-ecr-login@062b18b96a7aff071d4dc91bc00c4c1a7945b076 # v2.0.1
+        with:
+          registries: ${{ secrets.QA_AWS_ACCOUNT_NUMBER }}
+        env:
+          AWS_REGION: ${{ secrets.QA_AWS_REGION }}
 
       - name: Set up Go
-        if: steps.gate.outputs.should_run == 'true'
         uses: actions/setup-go@v6 # v6
         with:
           cache: true
           go-version-file: devenv/go.mod
           cache-dependency-path: devenv/go.sum
 
       - name: Download Go dependencies
-        if: steps.gate.outputs.should_run == 'true'
         run: |
           go mod download
 
       - name: Set environment variables
-        if: steps.gate.outputs.should_run == 'true'
         run: |
           echo "CHAINLINK_IMAGE=${{ needs.resolve-chainlink-image.outputs.resolved-image }}" >> $GITHUB_ENV
 
       - name: Setup environment
-        if: steps.gate.outputs.should_run == 'true'
         env:
           FAKE_SERVER_IMAGE: ${{ secrets.FAKE_SERVER_IMAGE }}
         run: |
@@ -383,7 +372,6 @@ jobs:
           eval $ENV_CMD
 
       - name: Run tests
-        if: steps.gate.outputs.should_run == 'true'
         working-directory: devenv/tests/${{ matrix.tests_dir }}
         env:
           CURRENT_TEST: ${{ matrix.testcmd }}
@@ -393,7 +381,6 @@ jobs:
           eval $TESTCMD
 
       - name: Upload Logs
-        if: always() && steps.gate.outputs.should_run == 'true'
         uses: actions/upload-artifact@v4
         with:
           name: container-logs-${{ matrix.logs_archive_name }}