Closed
Conversation
Contributor
|
I see you updated files related to
|
* test now fails because of "no bootstrappers found"
…eline runs are not being saved for some reason at the moment)
…"TODO(gg): update" * NB uses chainlink-common with added plugin type (in pkg/types/plugin.go)
…e PorReportingPluginFactory
jmank88
reviewed
Jun 13, 2025
| libocr | ||
| click libocr href "https://github.com/smartcontractkit/libocr" | ||
| por_mock_ocr3plugin --> libocr | ||
| click por_mock_ocr3plugin href "https://github.com/smartcontractkit/por_mock_ocr3plugin" |
Contributor
Author
There was a problem hiding this comment.
At some point it will be, not sure when that is though.
We shouldn't merge this PR before that, unless there's a workaround.
5 tasks
|
Contributor
Author
|
Superseded by #18442 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DF-21405 Run the secure mint plugin
Requires
Notes
It does not write to chain yet, that will come in a later PR.
NB
Do not merge until the plugin is loopified and/or public