Wire up ChipIngressInsecureConnection config option#18947
Merged
patrickhuie19 merged 11 commits intodevelopfrom Aug 22, 2025
Merged
Wire up ChipIngressInsecureConnection config option#18947patrickhuie19 merged 11 commits intodevelopfrom
patrickhuie19 merged 11 commits intodevelopfrom
Conversation
pkcll
added
build-publish
pkcll
force-pushed
the
INFOPLAT-2627-chip-ingress-client
branch
3 times, most recently
from
b4040c3 to
0bf041a
Compare
pkcll
force-pushed
the
INFOPLAT-2627-chip-ingress-client
branch
from
f9911e2 to
cb95c1c
Compare
pkcll
force-pushed
the
INFOPLAT-2627-chip-ingress-client
branch
from
cb95c1c to
edba26e
Compare
pkcll
changed the title
pkcll
changed the title
pkcll
changed the title
krehermann
approved these changes
Aug 21, 2025
krehermann
previously approved these changes
Aug 21, 2025
…INFOPLAT-2627-chip-ingress-client
Tofel
previously approved these changes
Aug 21, 2025
Contributor
Tofel
left a comment
Tofel
left a comment
There was a problem hiding this comment.
approved core/scripts/cre && system-tests/ parts
…INFOPLAT-2627-chip-ingress-client
…INFOPLAT-2627-chip-ingress-client
patrickhuie19
previously approved these changes
Aug 21, 2025
jmank88
previously approved these changes
Aug 21, 2025
krehermann
previously approved these changes
Aug 21, 2025
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
pkcll
dismissed stale reviews from krehermann, jmank88, and patrickhuie19
via
4718ee9
jmank88
approved these changes
Aug 22, 2025
|
krehermann
approved these changes
Aug 22, 2025
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
patrickhuie19
approved these changes
Aug 22, 2025
This was referenced Aug 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add ChipIngressInsecureConnection config option
Bump chainlink-common for smartcontractkit/chainlink-common#1495
Why
ChipIngress should use TLS by default, while Beholder/OTel does not use TLS for local connection to sidecar collector by default.