INFOPLAT-2449: Use chainlink-common otelzap core in chainlink global logger#19089
Merged
INFOPLAT-2449: Use chainlink-common otelzap core in chainlink global logger#19089
Conversation
Contributor
|
👋 kirqz23, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
jmank88
reviewed
Sep 2, 2025
jmank88
reviewed
Sep 5, 2025
jmank88
reviewed
Sep 5, 2025
jmank88
reviewed
Sep 8, 2025
jmank88
reviewed
Sep 8, 2025
jmank88
reviewed
Sep 8, 2025
jmank88
reviewed
Sep 9, 2025
jmank88
reviewed
Sep 12, 2025
pavel-raykov
approved these changes
Oct 14, 2025
jmank88
approved these changes
Oct 14, 2025
|
This was referenced Oct 14, 2025
This was referenced Nov 7, 2025
This was referenced Nov 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




What
Use
chainlink-commonotelzap core in chainlink global logger for exporting logs throughbeholderto Otel and Loki.Enables early logger setup with OTel support without requiring chainlink logger recreation when beholder is initialised. Leveraging atomic core for swapping noop core with otel core when Beholder is ready.
Related PRs:
How
beholderand it's dependencies in before hooks for subcommands. We introduced commonBeforeNode()andAfterNode()function that setups and clears all dependencies including database, datastore, keystore and beholder. The reference to db, keystore and datasource is stored in the shell.chainlink-commonotelzappackage with zap core for otel. To be able to initilize logger earlier (beforebeholderis ready in rootnodecommand), we leverage atomic functionality to swap atomic core for otel whenever beholder is ready in atomic operation to avoid race condition. Additionally, we implementedNewWithCores()that accepts additional cores (besides default one) that helped us achieve above.