[PRODCRE-1077] Flag for local capabilities + Launcher metrics#19919
[PRODCRE-1077] Flag for local capabilities + Launcher metrics#19919
Conversation
|
I see you updated files related to
|
| module github.com/smartcontractkit/chainlink/v2 | ||
|
|
||
| go 1.24.5 | ||
| go 1.25.3 |
There was a problem hiding this comment.
is anything forcing a go bump? or you just think its about time?
There was a problem hiding this comment.
yeah, new common is set to 1.25
| expectedError: "no such host", | ||
| }, | ||
| { | ||
| /*{ // TODO: failing with go 1.25 |
There was a problem hiding this comment.
@cedric-cordenier / @jmank88 - any idea why these started to break with Go 1.25? In playground they don't work with either... https://go.dev/play/p/XYO2ekdS5bx?v=goprev
There was a problem hiding this comment.
even weirder: tip does not error!
There was a problem hiding this comment.
Likely this? golang/go#75713
Only in newer patch release of 1.24 and 1.25
There was a problem hiding this comment.
wow good find thanks!
|
4 participants
Explicitly mark capabilities as local and skip them in Launcher (depends on smartcontractkit/chainlink-common#1616)
Additionally export a few new metrics from Launcher.
Also had to bump go to 1.25 with the new common.