Skip to content

bumping workflow source proto#21045

Merged
patrickhuie19 merged 6 commits into
developfrom
feat/proto-source-upgrade
Feb 10, 2026
Merged

bumping workflow source proto#21045
patrickhuie19 merged 6 commits into
developfrom
feat/proto-source-upgrade

Conversation

@patrickhuie19
Copy link
Copy Markdown
Contributor

@patrickhuie19 patrickhuie19 commented Feb 6, 2026 •
edited by jmank88
Loading

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 6, 2026

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 6, 2026 •
edited
Loading

CORA - Pending Reviewers

All codeowners have approved! ✅

Legend: ✅ Approved | ❌ Changes Requested | 💬 Commented | 🚫 Dismissed | ⏳ Pending | ❓ Unknown

For more details, see the full review summary.

@trunk-io
Copy link
Copy Markdown

trunk-io Bot commented Feb 6, 2026 •
edited
Loading

Static Badge   Static Badge   Static Badge   Static Badge

View Full Report ↗︎ ⋅ Docs

bolekk
bolekk previously approved these changes Feb 6, 2026
View reviewed changes
Comment thread core/capabilities/fakes/confidential_http_action.go
for name, value := range req.GetHeaders() {
httpReq.Header.Set(name, value)
// Add headers (supports multiple values per key)
for name, headerValues := range req.GetMultiHeaders() {
Copy link
Copy Markdown
Contributor

@bolekk bolekk Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @prashantkumar1982 ?

Copy link
Copy Markdown
Contributor

@jmank88 jmank88 Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to manually resolve conflicts here. IIUC the same change was already applied among some other complexity but please double check me.

Copy link
Copy Markdown
Contributor

@prashantkumar1982 prashantkumar1982 Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like there's a deadlock in these fixes.
See #21071
@nadahalli

justinkaseman
justinkaseman previously approved these changes Feb 6, 2026
View reviewed changes
@jmank88
Copy link
Copy Markdown
Contributor

jmank88 commented Feb 9, 2026

Conflicts Resolved

jmank88
jmank88 previously approved these changes Feb 9, 2026
View reviewed changes
vyzaldysanchez
vyzaldysanchez previously approved these changes Feb 9, 2026
View reviewed changes
@jmank88
Copy link
Copy Markdown
Contributor

jmank88 commented Feb 9, 2026

Two timeouts in a row 🤔

@jmank88
Copy link
Copy Markdown
Contributor

jmank88 commented Feb 10, 2026

Hmm still timing out

@nadahalli nadahalli mentioned this pull request Feb 10, 2026
Merged
@cl-sonarqube-production
Copy link
Copy Markdown

cl-sonarqube-production Bot commented Feb 10, 2026

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@teresawong567-afk
Copy link
Copy Markdown

teresawong567-afk commented Feb 22, 2026

Crypto can be rewarding if approached the right way. Learning from trusted sources and using verified platforms is key. With the guidance of Robert Oliver on WhatsApp +44 7459 127100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmank88 jmank88 jmank88 approved these changes

@bolekk bolekk bolekk approved these changes

@ecPablo ecPablo Awaiting requested review from ecPablo

@justinkaseman justinkaseman Awaiting requested review from justinkaseman

@george-dorin george-dorin Awaiting requested review from george-dorin

@pavel-raykov pavel-raykov Awaiting requested review from pavel-raykov

@mchain0 mchain0 Awaiting requested review from mchain0

@cedric-cordenier cedric-cordenier Awaiting requested review from cedric-cordenier

@vyzaldysanchez vyzaldysanchez Awaiting requested review from vyzaldysanchez

@prashantkumar1982 prashantkumar1982 Awaiting requested review from prashantkumar1982

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@patrickhuie19 @jmank88 @teresawong567-afk @bolekk @vyzaldysanchez @justinkaseman @prashantkumar1982