Skip to content

Move encrypt_output access from ConfidentialHTTPRequest to HTTPRequest#21071

Merged
prashantkumar1982 merged 4 commits into
developfrom
move-encrypt-output-to-http-request
Feb 10, 2026
Merged

Move encrypt_output access from ConfidentialHTTPRequest to HTTPRequest#21071
prashantkumar1982 merged 4 commits into
developfrom
move-encrypt-output-to-http-request

Conversation

@nadahalli
Copy link
Copy Markdown
Contributor

@nadahalli nadahalli commented Feb 9, 2026 •
edited
Loading

Summary

  • Move encrypt_output access from the outer ConfidentialHTTPRequest wrapper to the inner HTTPRequest, following chainlink-protos#291
  • Bump chainlink-common to a82fa419e483 and chainlink-protos/cre/go to a488315d180f across all 7 submodules

Depends on

- #21045 — bumps workflow source protos (must merge first, then rebase this PR)

Breaking changes

Follow-up to chainlink-protos#291 which moved encrypt_output from ConfidentialHTTPRequest (field 3) to HTTPRequest (field 9). The field is not yet used in production.

Code changes

core/capabilities/fakes/confidential_http_action.go

// Before:
if input.GetEncryptOutput() {
// After:
if input.GetRequest().GetEncryptOutput() {

Related PRs

@nadahalli nadahalli requested review from a team as code owners February 9, 2026 22:04
Copilot AI review requested due to automatic review settings February 9, 2026 22:04
@nadahalli nadahalli requested review from a team as code owners February 9, 2026 22:04
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 9, 2026

👋 nadahalli, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

Copilot AI reviewed Feb 9, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the fake confidential HTTP capability to read encrypt_output from the inner HTTPRequest (per proto change), and bumps module dependencies to pick up regenerated types.

Changes:

  • Read encrypt_output via input.GetRequest().GetEncryptOutput() instead of input.GetEncryptOutput()
  • Bump chainlink-common and chainlink-protos/* pseudo-versions across modules
  • Add chainlink-protos/node-platform as an indirect dependency where required

Reviewed changes

Copilot reviewed 8 out of 15 changed files in this pull request and generated no comments.

Show a summary per file
File Description
system-tests/tests/go.mod Bumps chainlink-common/chainlink-protos versions to align with regenerated types
system-tests/lib/go.mod Bumps chainlink-common/chainlink-protos versions; adds node-platform indirect
integration-tests/load/go.mod Bumps chainlink-common/chainlink-protos versions; adds node-platform indirect
integration-tests/go.mod Bumps chainlink-common/chainlink-protos versions; adds node-platform indirect
go.mod Bumps chainlink-common/chainlink-protos versions; adds node-platform indirect
deployment/go.mod Bumps chainlink-common/chainlink-protos versions; adds node-platform indirect
core/scripts/go.mod Bumps chainlink-common/chainlink-protos versions; adds node-platform indirect
core/capabilities/fakes/confidential_http_action.go Switches encrypt_output lookup to the inner HTTPRequest

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 9, 2026 •
edited
Loading

CORA - Pending Reviewers

All codeowners have approved! ✅

Legend: ✅ Approved | ❌ Changes Requested | 💬 Commented | 🚫 Dismissed | ⏳ Pending | ❓ Unknown

For more details, see the full review summary.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 9, 2026

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@nadahalli nadahalli mentioned this pull request Feb 9, 2026
Closed
@trunk-io
Copy link
Copy Markdown

trunk-io Bot commented Feb 10, 2026 •
edited
Loading

Static Badge   Static Badge   Static Badge   Static Badge

View Full Report ↗︎ ⋅ Docs

@prashantkumar1982 prashantkumar1982 mentioned this pull request Feb 10, 2026
Merged
@nadahalli
Move encrypt_output access from ConfidentialHTTPRequest to HTTPRequest
4e3c205 
Bump chainlink-common to a82fa419e483 and chainlink-protos/cre/go to
a488315d180f across all submodules. Access EncryptOutput via
GetRequest().GetEncryptOutput() since the field moved from the outer
wrapper to HTTPRequest.
@nadahalli nadahalli requested a review from vreff February 10, 2026 14:30
vreff
vreff previously approved these changes Feb 10, 2026
View reviewed changes
@cl-sonarqube-production
Copy link
Copy Markdown

cl-sonarqube-production Bot commented Feb 10, 2026

Quality Gate failed Quality Gate failed

Failed conditions
E Maintainability Rating on New Code (required ≥ A)
60.0% Technical Debt Ratio on New Code (required ≤ 4%)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarQube IDE SonarQube IDE

@prashantkumar1982 prashantkumar1982 added this pull request to the merge queue Feb 10, 2026
Merged via the queue into develop with commit ed01b84 Feb 10, 2026
253 of 255 checks passed
@prashantkumar1982 prashantkumar1982 deleted the move-encrypt-output-to-http-request branch February 10, 2026 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@jmank88 jmank88 jmank88 approved these changes

@prashantkumar1982 prashantkumar1982 prashantkumar1982 approved these changes

@vreff vreff vreff approved these changes

@pavel-raykov pavel-raykov pavel-raykov approved these changes

@ChrisAmora ChrisAmora Awaiting requested review from ChrisAmora

@MStreet3 MStreet3 Awaiting requested review from MStreet3

@fernandofederico1984 fernandofederico1984 Awaiting requested review from fernandofederico1984

+1 more reviewer

@krehermann krehermann krehermann approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@nadahalli @jmank88 @krehermann @prashantkumar1982 @vreff @pavel-raykov