Skip to content

[DX-2591] migrate solana tests to devenv#21447

Merged
Tofel merged 1 commit intodevelopfrom
dx-2591-migrate-solana-tests-to-devenv
Mar 20, 2026
Merged

[DX-2591] migrate solana tests to devenv#21447
Tofel merged 1 commit intodevelopfrom
dx-2591-migrate-solana-tests-to-devenv

Conversation

@Tofel
Copy link
Copy Markdown
Contributor

@Tofel Tofel commented Mar 6, 2026

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 6, 2026

✅ No conflicts with other open PRs targeting develop

@trunk-io
Copy link
Copy Markdown

trunk-io Bot commented Mar 6, 2026

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

@Tofel Tofel force-pushed the dx-2591-migrate-solana-tests-to-devenv branch 2 times, most recently from 694e212 to e426dcc Compare March 9, 2026 11:21
@Tofel Tofel added run-e2e-tests Use on your PR to run E2E tests before the merge queue and removed run-e2e-tests Use on your PR to run E2E tests before the merge queue labels Mar 20, 2026
@github-actions
Copy link
Copy Markdown
Contributor

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@Tofel Tofel marked this pull request as ready for review March 20, 2026 07:23
@Tofel Tofel requested review from a team as code owners March 20, 2026 07:23
Copilot AI review requested due to automatic review settings March 20, 2026 07:23
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Risk Rating: MEDIUM

This PR updates the Chainlink Solana dependency and switches Solana smoke test execution in CI to a reusable workflow (as part of migrating Solana tests to devenv / updated execution path).

Changes:

  • Bump github.com/smartcontractkit/chainlink-solana to v1.1.2-0.20260320011913-f2205f8506c7 across root, integration-tests, system-tests, deployment, and scripts modules.
  • Update Solana plugin gitRef in plugins/plugins.public.yaml to the same Chainlink Solana version.
  • Replace the inline Solana test image/artifact build + test steps in .github/workflows/integration-tests.yml with a reusable workflow call.

Reviewed changes

Copilot reviewed 9 out of 16 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
.github/workflows/integration-tests.yml Switch Solana smoke tests to a reusable workflow; modifies Solana test gating logic.
go.mod / go.sum Bump Chainlink Solana dependency version at the repo root.
deployment/go.mod / deployment/go.sum Align deployment module’s Chainlink Solana dependency version.
core/scripts/go.mod / core/scripts/go.sum Align scripts module’s Chainlink Solana dependency version.
integration-tests/go.mod / integration-tests/go.sum Align integration-tests module’s Chainlink Solana dependency version.
integration-tests/load/go.mod / integration-tests/load/go.sum Align load-tests module’s Chainlink Solana dependency version.
system-tests/lib/go.mod / system-tests/lib/go.sum Align system-tests lib module’s Chainlink Solana dependency version.
system-tests/tests/go.mod / system-tests/tests/go.sum Align system-tests tests module’s Chainlink Solana dependency version.
plugins/plugins.public.yaml Update Solana plugin gitRef to the new Chainlink Solana version.

Areas needing scrupulous human review:

  • .github/workflows/integration-tests.yml Solana gating logic and the correctness of the reusable workflow invocation (inputs/secrets/permissions) since this changes CI behavior and relies on a cross-repo workflow call.
  • Confirm the called reusable workflow provides equivalent artifacts/logs/coverage expectations (since the prior inline job did explicit artifact upload/coverage handling).

Suggested reviewers (per CODEOWNERS):

  • @smartcontractkit/devex-cicd, @smartcontractkit/devex-tooling, @smartcontractkit/core (CI/workflows and integration-tests ownership)
  • @smartcontractkit/foundations / @smartcontractkit/core (root go.mod / go.sum ownership)

Comment thread .github/workflows/integration-tests.yml Outdated
@Tofel Tofel requested review from Unheilbar and augustbleeds March 20, 2026 10:00
@Tofel Tofel enabled auto-merge March 20, 2026 11:34
@Tofel Tofel force-pushed the dx-2591-migrate-solana-tests-to-devenv branch from b8ade4c to 22e9cea Compare March 20, 2026 13:58
@Tofel Tofel added this pull request to the merge queue Mar 20, 2026
@cl-sonarqube-production
Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 20, 2026
@Tofel Tofel added this pull request to the merge queue Mar 20, 2026
Merged via the queue into develop with commit 7dec4e2 Mar 20, 2026
260 of 304 checks passed
@Tofel Tofel deleted the dx-2591-migrate-solana-tests-to-devenv branch March 20, 2026 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants