Skip to content

lint fixes#21569

Merged
jmank88 merged 1 commit intodevelopfrom
lint-fixes
Mar 20, 2026
Merged

lint fixes#21569
jmank88 merged 1 commit intodevelopfrom
lint-fixes

Conversation

@jmank88
Copy link
Copy Markdown
Contributor

@jmank88 jmank88 commented Mar 17, 2026 •
edited
Loading

Add build-tags to config and fix issues.

@jmank88 jmank88 requested review from a team as code owners March 17, 2026 21:58
@jmank88 jmank88 enabled auto-merge March 17, 2026 21:58
@jmank88 jmank88 requested a review from pavel-raykov March 17, 2026 21:58
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 17, 2026 •
edited
Loading

CORA - Pending Reviewers

All codeowners have approved! ✅

Legend: ✅ Approved | ❌ Changes Requested | 💬 Commented | 🚫 Dismissed | ⏳ Pending | ❓ Unknown

For more details, see the full review summary.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 17, 2026 •
edited
Loading

✅ No conflicts with other open PRs targeting develop

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 17, 2026

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@trunk-io
Copy link
Copy Markdown

trunk-io Bot commented Mar 18, 2026 •
edited
Loading

Static Badge   Static Badge   Static Badge   Static Badge

View Full Report ↗︎ ⋅ Docs

@jmank88 jmank88 added the allow-lint-issues Allow merging despite linter issues. Do not abuse. label Mar 18, 2026
@cl-sonarqube-production
Copy link
Copy Markdown

cl-sonarqube-production Bot commented Mar 18, 2026

Quality Gate passed Quality Gate passed

Issues
1 New issue
1 Fixed issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.6% Duplication on New Code

See analysis details on SonarQube

@jmank88 jmank88 added this pull request to the merge queue Mar 20, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 20, 2026
@jmank88 jmank88 added this pull request to the merge queue Mar 20, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 20, 2026
@jmank88 jmank88 added this pull request to the merge queue Mar 20, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 20, 2026
@jmank88 jmank88 added this pull request to the merge queue Mar 20, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 20, 2026
@jmank88 jmank88 added this pull request to the merge queue Mar 20, 2026
Merged via the queue into develop with commit 5638f16 Mar 20, 2026
228 of 231 checks passed
@jmank88 jmank88 deleted the lint-fixes branch March 20, 2026 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ibrajer ibrajer ibrajer approved these changes

@KodeyThomas KodeyThomas KodeyThomas approved these changes

@Unheilbar Unheilbar Unheilbar approved these changes

@prashantkumar1982 prashantkumar1982 prashantkumar1982 approved these changes

@Farber98 Farber98 Farber98 approved these changes

@graham-chainlink graham-chainlink graham-chainlink approved these changes

@winder winder Awaiting requested review from winder winder is a code owner automatically assigned from smartcontractkit/ccip-offchain

@makramkd makramkd Awaiting requested review from makramkd makramkd is a code owner automatically assigned from smartcontractkit/ccip-offchain

@AmrMohamedRezk AmrMohamedRezk Awaiting requested review from AmrMohamedRezk AmrMohamedRezk is a code owner automatically assigned from smartcontractkit/ccip-offchain

@agusaldasoro agusaldasoro Awaiting requested review from agusaldasoro agusaldasoro is a code owner automatically assigned from smartcontractkit/ccip-offchain

@ogtownsend ogtownsend Awaiting requested review from ogtownsend ogtownsend is a code owner automatically assigned from smartcontractkit/ccip-offchain

@tt-cll tt-cll Awaiting requested review from tt-cll tt-cll is a code owner automatically assigned from smartcontractkit/ccip-offchain

@b-gopalswami b-gopalswami Awaiting requested review from b-gopalswami b-gopalswami is a code owner automatically assigned from smartcontractkit/ccip-offchain

@pavel-raykov pavel-raykov Awaiting requested review from pavel-raykov

@anirudhwarrier anirudhwarrier Awaiting requested review from anirudhwarrier

@Atrax1 Atrax1 Awaiting requested review from Atrax1

@j-nowak j-nowak Awaiting requested review from j-nowak

@lawrencexia lawrencexia Awaiting requested review from lawrencexia

@leeyikjiun leeyikjiun Awaiting requested review from leeyikjiun

@patrickhuie19 patrickhuie19 Awaiting requested review from patrickhuie19

@tarcisiozf tarcisiozf Awaiting requested review from tarcisiozf

@timothyF95 timothyF95 Awaiting requested review from timothyF95

@silaslenihan silaslenihan Awaiting requested review from silaslenihan

@bolekk bolekk Awaiting requested review from bolekk

@denis-chernov-smartcontract denis-chernov-smartcontract Awaiting requested review from denis-chernov-smartcontract

@matYang matYang Awaiting requested review from matYang

@asoliman92 asoliman92 Awaiting requested review from asoliman92

+1 more reviewer

@infiloop2 infiloop2 infiloop2 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

allow-lint-issues Allow merging despite linter issues. Do not abuse.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@jmank88 @ibrajer @KodeyThomas @Unheilbar @prashantkumar1982 @Farber98 @infiloop2 @graham-chainlink