Skip to content

core/capabilities: reduce long log lines#21579

Merged
jmank88 merged 1 commit intodevelopfrom
long-logs
Mar 20, 2026
Merged

core/capabilities: reduce long log lines#21579
jmank88 merged 1 commit intodevelopfrom
long-logs

Conversation

@jmank88
Copy link
Copy Markdown
Contributor

@jmank88 jmank88 commented Mar 18, 2026

This PR reduces long log lines by moving the details to trace level.

@github-actions
Copy link
Copy Markdown
Contributor

👋 jmank88, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

}
}
w.lggr.Debugw("Found my capability DONs", "count", len(myCapabilityDONs), "myCapabilityDONs", myCapabilityDONs)
w.lggr.Debugw("Found all remote capability DONs", "count", len(remoteCapabilityDONs), "remoteCapabilityDONs", remoteCapabilityDONs)
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

38KiB

remoteWorkflowDONs = filterDONsByFamilies(remoteWorkflowDONs, myDONFamilies)
remoteCapabilityDONs = filterDONsByFamilies(remoteCapabilityDONs, myDONFamilies)
w.lggr.Debugw("Filtered remote workflow DONs to my families", "count", len(remoteWorkflowDONs), "remoteWorkflowDONs", remoteWorkflowDONs)
w.lggr.Debugw("Filtered remote capability DONs to my families", "count", len(remoteCapabilityDONs), "remoteCapabilityDONs", remoteCapabilityDONs)
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

35KiB

@github-actions
Copy link
Copy Markdown
Contributor

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 18, 2026

✅ No conflicts with other open PRs targeting develop

@jmank88 jmank88 requested a review from pavel-raykov March 18, 2026 14:15
pavel-raykov
pavel-raykov previously approved these changes Mar 18, 2026

rpt := r.FormatReport()

r.lggr.Debug("Emitting metering report", "report", rpt, "stepRefs", strings.Join(r.stepRefLookup, ","))
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

16KiB

@cl-sonarqube-production
Copy link
Copy Markdown

@jmank88 jmank88 requested a review from pavel-raykov March 18, 2026 15:34
@jmank88 jmank88 requested a review from bolekk March 18, 2026 16:09
@trunk-io
Copy link
Copy Markdown

trunk-io Bot commented Mar 18, 2026

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

@jmank88 jmank88 added this pull request to the merge queue Mar 20, 2026
Merged via the queue into develop with commit 38b9873 Mar 20, 2026
185 of 187 checks passed
@jmank88 jmank88 deleted the long-logs branch March 20, 2026 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants