Skip to content

core/services/workflows/v2: add cre context to workflow_execution traces #21619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmank88 merged 1 commit into from
Mar 23, 2026
+5 −0
Merged

core/services/workflows/v2: add cre context to workflow_execution traces #21619

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions core/services/workflows/v2/engine.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -592,11 +592,15 @@ func (e *Engine) handleAllTriggerEvents(ctx context.Context) {
e.logger().Debugw("Scheduling a trigger event for execution", "eventID", eventID)
e.srvcEng.GoCtx(context.WithoutCancel(ctx), func(ctx context.Context) {
defer free()
creCtx := contexts.CREValue(ctx)
// Tracer is no-op if DebugMode is false
ctx, span := e.tracer.Start(ctx, "workflow_execution",
trace.WithAttributes(
attribute.String("workflow_name", e.cfg.WorkflowName.String()),
attribute.String("version", "v2"),
attribute.String("org_id", creCtx.Org),
attribute.String("owner_id", creCtx.Owner),
attribute.String("workflow_id", creCtx.Workflow),
))
defer span.End()
e.startExecution(ctx, queueHead)
Expand Down Expand Up @@ -660,6 +664,7 @@ func (e *Engine) startExecution(ctx context.Context, wrappedTriggerEvent enqueue
}
e.metrics.IncrementExecutionIDLegacyCounter(ctx)
}
trace.SpanFromContext(ctx).SetAttributes(attribute.String("execution_id", executionID))
Copy link
Copy Markdown
Contributor Author

@jmank88 jmank88 Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to correct variable


// disallow duplicate executions
_, addErr := e.cfg.ExecutionsStore.Add(ctx, nil, executionID, e.cfg.WorkflowID, store.StatusStarted)
Expand Down
Loading