Conversation
Contributor
|
👋 kalverra, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
kalverra
added
the
run-e2e-tests
Contributor
|
✅ No conflicts with other open PRs targeting |
Tofel
previously approved these changes
Mar 20, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Risk Rating: HIGH (CI workflow changes across multiple pipelines; current diff includes workflow-breaking YAML issues)
This PR updates multiple GitHub Actions workflows to use an environment without creating deployments (via environment: { name: integration, deployment: false }) and removes per-workflow cleanup jobs that were deleting environment deployments.
Changes:
- Convert
environment: integration/"integration"to the expandedenvironment:object withdeployment: falseacross several workflows. - Remove
cleanupjobs from integration test workflows that previously deleted environment deployments. - Minor workflow formatting tweaks (e.g., quoting consistency).
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/integration-tests.yml | Switches jobs to environment: { name: integration, deployment: false } and removes the cleanup job. |
| .github/workflows/integration-in-memory-tests.yml | Switches to environment object form and removes the cleanup job. |
| .github/workflows/devenv-compat.yml | Switches to environment object form with deployment: false. |
| .github/workflows/delete-deployments.yml | Modifies inputs to the delete-deployments action (currently broken YAML / missing environment: input key). |
| .github/workflows/cre-workflow-don-benchmark.yaml | Switches to environment object form with deployment: false. |
| .github/workflows/cre-system-tests.yaml | Switches to environment object form with deployment: false. |
| .github/workflows/cre-soak-memory-leak.yml | Attempts to change environment, but currently corrupts runs-on and drops/misplaces environment. |
| .github/workflows/cre-regression-system-tests.yaml | Switches to environment object form with deployment: false. |
| .github/workflows/cre-local-env-tests.yaml | Switches relevant jobs to environment object form with deployment: false. |
| .github/workflows/client-compatibility-tests.yml | Switches multiple jobs to environment object form with deployment: false; minor quoting tweak. |
Areas requiring scrupulous human review:
.github/workflows/delete-deployments.yml(with:block inputs) and.github/workflows/cre-soak-memory-leak.yml(runs-on/environment) because they will likely prevent workflows from running.- Confirm that
deployment: falsebehaves as intended for all affected workflows (e.g., no deployments created, required reviewers/branch protections still behave correctly). - Validate that removing cleanup jobs doesn’t leave any other deployment artifacts created elsewhere in the workflows (manual deployment creation, other actions, etc.).
Reviewer recommendations (per .github/CODEOWNERS for /.github/**):
@smartcontractkit/devex-cicd@smartcontractkit/devex-tooling@smartcontractkit/core
erikburt
reviewed
Mar 20, 2026
erikburt
approved these changes
Mar 20, 2026
Tofel
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.