[DX-3567] save price provider logs to a file#21634
Merged
Conversation
Contributor
|
✅ No conflicts with other open PRs targeting |
product-security-plaid-production
Bot
requested review from
kdihalas,
pavel-raykov and
skudasov
Tofel
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Risk Rating: MEDIUM
This PR reduces log volume/noise during the CRE PoR memory-leak soak test by redirecting the fake price provider’s logs away from GitHub Actions stdout, and adjusts the CI workflow runner configuration for the soak job.
Changes:
- Redirect fake price provider logs to a dedicated log file via a separate zerolog logger.
- Increase the runner resources for the soak workflow job.
- Gate the “Enable S3 Cache” step behind an env-var presence check.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
system-tests/tests/soak/cre/soak_test.go |
Adds a dedicated logger that writes fake price provider logs to ./logs/soak-fake-price-provider.log and passes it into the soak price provider. |
.github/workflows/cre-soak-memory-leak.yml |
Updates runner sizing for the soak job and conditionally runs the S3 cache enabling step. |
Scrupulous human review suggested for:
- The new log file path/creation behavior and whether artifacts capture the redirected logs as intended.
- The workflow runner sizing change (availability/cost/queue impact).
Suggested reviewers (per CODEOWNERS):
- For
.github/workflows/**:@smartcontractkit/devex-cicd,@smartcontractkit/devex-tooling,@smartcontractkit/core - For
system-tests/**(falls back to repo root owners):@smartcontractkit/foundations,@smartcontractkit/core
kdihalas
previously approved these changes
Mar 25, 2026
pavel-raykov
previously approved these changes
Mar 25, 2026
|
Tofel
changed the title
mchain0
approved these changes
Mar 26, 2026
jmank88
approved these changes
Mar 26, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
prashantkumar1982
pushed a commit
that referenced
this pull request
Apr 2, 2026
* use sampling logger for CRE soak test * throw more HDD at the runner, save fake data provider logs to a file * add debug to runs-on, use more powerful runner * redirect Gin output to log file * do not close the log file on test clean up as gin writes to it after the clean up
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why? Otherwise price provider creates so much noise it crashes GIthub's UI.
Test execution: https://github.com/smartcontractkit/chainlink/actions/runs/23501384861/job/68397092504
Also: use more powerful runner.
Last, but not least... that memory leak test now completes, but fails, because memory usage is way above the threshold.