solana/cs_token_pool : fallback to erc20 decimals for pools without getTokenDecimals#21698
Merged
0xsuryansh merged 1 commit intodevelopfrom Apr 27, 2026
Conversation
Contributor
|
✅ No conflicts with other open PRs targeting |
0xsuryansh
requested review from
AmrMohamedRezk,
agusaldasoro,
asoliman92,
b-gopalswami,
makramkd,
ogtownsend and
winder
|
0xsuryansh
changed the title
0xsuryansh
changed the title
tt-cll
approved these changes
Mar 25, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Risk Rating: MEDIUM
This PR updates the Solana v0.1.1 token-pool changeset logic to determine EVM token decimals more robustly by falling back to querying the underlying ERC20 token when the pool’s getTokenDecimals call fails.
Changes:
- Introduces an ERC20-based fallback for fetching decimals when
evmTokenPool.GetTokenDecimals(...)errors. - Reuses a single
bind.CallOptsinstance for the EVM calls withingetOnChainEVMPoolConfig. - Adds an ERC20 wrapper dependency to support the fallback decimals query.
gustavogama-cll
approved these changes
Apr 27, 2026
0xsuryansh
deleted the
0xsuryansh/add-support-to-pools-without-getTokenDecimals
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.