Conversation
|
👋 ettec, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
|
✅ No conflicts with other open PRs targeting |
There was a problem hiding this comment.
Pull request overview
Risk Rating: LOW
Removes references to deprecated testing capability plugins from the loopinstall testing plugins manifest.
Changes:
- Removed the
mockandcapabilitywatcherentries fromplugins/plugins.testing.yaml. - Left
plugins/plugins.testing.yamlas an effectively empty manifest (no testing plugins).
| @@ -9,14 +9,5 @@ defaults: | |||
| goflags: "-ldflags=-s" | |||
|
|
|||
| plugins: | |||
There was a problem hiding this comment.
plugins: is currently declared with no value, which YAML interprets as null rather than an empty map. Since this file is consumed by loopinstall (via make install-plugins-testing / Docker builds), it’s safer and clearer to make this explicitly an empty map (e.g., plugins: {}) or remove the key if the tool supports it, to avoid schema/decoder differences treating null as invalid.
| plugins: | |
| plugins: {} |
|
Confirmed with @george-dorin that these capabilities are dead