Skip to content

default errors from capabilities will be marked as Internal errors in…#21752

Merged
bolekk merged 1 commit intodevelopfrom
fixRemoteErrorsUnwrapping2
Mar 27, 2026
Merged

default errors from capabilities will be marked as Internal errors in…#21752
bolekk merged 1 commit intodevelopfrom
fixRemoteErrorsUnwrapping2

Conversation

@fernandezlautaro
Copy link
Copy Markdown
Contributor

…stead of Unknown/Bug
Follow up of #21746

Requires

Supports

@fernandezlautaro fernandezlautaro requested a review from a team as a code owner March 27, 2026 14:47
Copilot AI review requested due to automatic review settings March 27, 2026 14:47
@github-actions
Copy link
Copy Markdown
Contributor

👋 fernandezlautaro, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@github-actions
Copy link
Copy Markdown
Contributor

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@github-actions
Copy link
Copy Markdown
Contributor

✅ No conflicts with other open PRs targeting develop

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Risk Rating: LOW

Follow-up to #21746 to ensure workflow capability execution failures that do not return a typed caperrors.Error are accounted for as Internal failures (instead of a “BUG”/unknown bucket), improving metrics consistency for remote capability error handling.

Changes:

  • Update capability failure metric label for untyped errors to use caperrors.Internal.String().
  • Adjust structured logging key for system-origin capability errors (errsystemErr).

@trunk-io
Copy link
Copy Markdown

trunk-io Bot commented Mar 27, 2026

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

@cl-sonarqube-production
Copy link
Copy Markdown

@bolekk bolekk added this pull request to the merge queue Mar 27, 2026
Merged via the queue into develop with commit abb10a2 Mar 27, 2026
211 of 214 checks passed
@bolekk bolekk deleted the fixRemoteErrorsUnwrapping2 branch March 27, 2026 15:35
prashantkumar1982 pushed a commit that referenced this pull request Apr 2, 2026
#21752)

default errors from capabilities will be marked as Internal errors instead of Unknown/Bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants