Skip to content

Set node platform build info beat to 3 minutes#21777

Merged
gheorghestrimtu merged 1 commit intodevelopfrom
chore/node-platform-build-info-beat-3m
Mar 31, 2026
Merged

Set node platform build info beat to 3 minutes#21777
gheorghestrimtu merged 1 commit intodevelopfrom
chore/node-platform-build-info-beat-3m

Conversation

@gheorghestrimtu
Copy link
Copy Markdown
Collaborator

This PR reduces the node platform build info emission cadence from the global telemetry heartbeat to a fixed 3m interval.

Previously, NodePlatformBuildInfoService used Telemetry().HeartbeatInterval(), which defaults to 1s, so build info could be emitted once per second. That is more frequent than needed for static build metadata. This change makes the service use its own explicit 3 * time.Minute beat instead.

It also adds a test to verify the node platform build info config stays at 3m even when the global telemetry heartbeat is set to a different value.

@gheorghestrimtu gheorghestrimtu added the build-publish Build and Publish image to SDLC label Mar 30, 2026
@github-actions
Copy link
Copy Markdown
Contributor

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@github-actions
Copy link
Copy Markdown
Contributor

✅ No conflicts with other open PRs targeting develop

@cl-sonarqube-production
Copy link
Copy Markdown

@trunk-io
Copy link
Copy Markdown

trunk-io Bot commented Mar 30, 2026

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

@gheorghestrimtu gheorghestrimtu marked this pull request as ready for review March 30, 2026 17:00
@gheorghestrimtu gheorghestrimtu requested review from a team as code owners March 30, 2026 17:00
Copilot AI review requested due to automatic review settings March 30, 2026 17:00
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Risk Rating: MEDIUM (changes runtime telemetry emission frequency; low code complexity but potentially impacts observability/consumers)

Reduces the node-platform build info emission cadence by decoupling it from the global telemetry heartbeat and using a fixed 3-minute interval instead, with a test to prevent regressions.

Changes:

  • Introduce a dedicated nodePlatformBeat = 3 * time.Minute constant for node-platform build info emissions.
  • Update NewNodePlatformBuildInfoConfig to use the fixed beat rather than Telemetry().HeartbeatInterval().
  • Add a unit test ensuring the beat remains 3m even if the global telemetry heartbeat is configured differently.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
core/services/chainlink/node_platform.go Switches build info beat from global heartbeat-derived to a fixed 3-minute interval via a new constant.
core/services/chainlink/node_platform_test.go Adds regression test asserting build info beat is 3m even when telemetry heartbeat is overridden.

Areas for scrupulous human review:

  • Confirm operational expectations around time-to-first emission (service currently only emits on ticker ticks) and whether a 3-minute interval is acceptable for downstream consumers of node build info.

Reviewer recommendations (per .github/CODEOWNERS):

  • @smartcontractkit/foundations, @smartcontractkit/core

Comment thread core/services/chainlink/node_platform.go
@gheorghestrimtu gheorghestrimtu requested a review from jmank88 March 30, 2026 20:08
@gheorghestrimtu gheorghestrimtu added this pull request to the merge queue Mar 31, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 31, 2026
@gheorghestrimtu gheorghestrimtu added this pull request to the merge queue Mar 31, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 31, 2026
@gheorghestrimtu gheorghestrimtu added this pull request to the merge queue Mar 31, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 31, 2026
@gheorghestrimtu gheorghestrimtu added this pull request to the merge queue Mar 31, 2026
Merged via the queue into develop with commit 562f283 Mar 31, 2026
246 of 257 checks passed
@gheorghestrimtu gheorghestrimtu deleted the chore/node-platform-build-info-beat-3m branch March 31, 2026 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build-publish Build and Publish image to SDLC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants