Skip to content

fix/bind-workflow-registry-once #21856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mchain0 merged 4 commits into from
Apr 7, 2026
+11 −10
Merged

fix/bind-workflow-registry-once #21856

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a480a08
fix/bind-workflow-registry-once
mchain0 Apr 3, 2026
93ee367
Merge branch 'develop' into fix/bind-workflow-registry-once
mchain0 Apr 7, 2026
3e4ce8d
Merge branch 'develop' into fix/bind-workflow-registry-once
mchain0 Apr 7, 2026
7439a69
develop merge fix
mchain0 Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions core/services/cre/cre.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -844,6 +844,7 @@ func newWorkflowRegistrySyncerV2(
gatewayConnectorWrapper *gatewayconnector.ServiceWrapper,
) (syncerV2.WorkflowRegistrySyncer, []commonsrv.Service, error) {
capCfg := cfg.Capabilities()
wfReg := capCfg.WorkflowRegistry()
key := opts.WorkflowKey

fetcherFunc, retrieverFunc, srvcs, err := newFetcherServiceV2(opts, capCfg, lggr, gatewayConnectorWrapper)
Expand All @@ -862,13 +863,13 @@ func newWorkflowRegistrySyncerV2(
lf,
artifactsV2.WithMaxArtifactSize(
artifactsV2.ArtifactConfig{
MaxBinarySize: uint64(capCfg.WorkflowRegistry().MaxBinarySize()),
MaxSecretsSize: uint64(capCfg.WorkflowRegistry().MaxEncryptedSecretsSize()),
MaxConfigSize: uint64(capCfg.WorkflowRegistry().MaxConfigSize()),
MaxBinarySize: uint64(wfReg.MaxBinarySize()),
MaxSecretsSize: uint64(wfReg.MaxEncryptedSecretsSize()),
MaxConfigSize: uint64(wfReg.MaxConfigSize()),
},
),
artifactsV2.WithConfig(artifactsV2.StoreConfig{
ArtifactStorageHost: capCfg.WorkflowRegistry().WorkflowStorage().ArtifactStorageHost(),
ArtifactStorageHost: wfReg.WorkflowStorage().ArtifactStorageHost(),
}),
)
if err != nil {
Expand All @@ -887,7 +888,7 @@ func newWorkflowRegistrySyncerV2(
return nil, nil, fmt.Errorf("could not instantiate engine feature flags: %w", err)
}

selector, err := chainSelector(capCfg.WorkflowRegistry().ChainID(), capCfg.WorkflowRegistry().NetworkID())
selector, err := chainSelector(wfReg.ChainID(), wfReg.NetworkID())
if err != nil {
return nil, nil, fmt.Errorf("failed to get workflow registry chain details by chain ID and network ID: %w", err)
}
Expand Down Expand Up @@ -937,7 +938,7 @@ func newWorkflowRegistrySyncerV2(
key,
workflowDonNotifier,
syncerV2.WithBillingClient(billingClient),
syncerV2.WithWorkflowRegistry(capCfg.WorkflowRegistry().Address(), selector),
syncerV2.WithWorkflowRegistry(wfReg.Address(), selector),
syncerV2.WithOrgResolver(orgResolver),
syncerV2.WithDebugMode(cfg.CRE().DebugMode()),
syncerV2.WithLocalSecrets(lggr, cfg.CRE().LocalSecrets()),
Expand All @@ -948,7 +949,7 @@ func newWorkflowRegistrySyncerV2(
return nil, nil, fmt.Errorf("unable to create workflow registry event handler: %w", err)
}

addSources := capCfg.WorkflowRegistry().AdditionalSources()
addSources := wfReg.AdditionalSources()
addSourceConfigs := make([]syncerV2.AdditionalSourceConfig, len(addSources))
for i, src := range addSources {
addSourceConfigs[i] = syncerV2.AdditionalSourceConfig{
Expand All @@ -962,7 +963,7 @@ func newWorkflowRegistrySyncerV2(
registryOpts := []syncerV2.Option{
syncerV2.WithAdditionalSources(addSourceConfigs),
syncerV2.WithShardOrchestratorClient(shardOrchestratorClient),
syncerV2.WithMaxConcurrency(capCfg.WorkflowRegistry().MaxConcurrency()),
syncerV2.WithMaxConcurrency(wfReg.MaxConcurrency()),
}
if cfg.Sharding().ShardingEnabled() {
registryOpts = append(registryOpts,
Expand All @@ -977,11 +978,11 @@ func newWorkflowRegistrySyncerV2(
workflowRegistrySyncerV2, err := syncerV2.NewWorkflowRegistry(
lggr,
crFactory,
capCfg.WorkflowRegistry().Address(),
wfReg.Address(),
selector,
syncerV2.Config{
QueryCount: 100,
SyncStrategy: syncerV2.SyncStrategy(capCfg.WorkflowRegistry().SyncStrategy()),
SyncStrategy: syncerV2.SyncStrategy(wfReg.SyncStrategy()),
},
eventHandler,
workflowDonNotifier,
Expand Down
Loading