Skip to content

remove unuse codeAt call from newRegisteredDon #21863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Unheilbar wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

remove unuse codeAt call from newRegisteredDon #21863

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52e6763
remove unuse codeAt call from newRegisteredDon
Unheilbar Apr 3, 2026
1d05ae8
fix return err on getDONs call
Unheilbar Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions deployment/keystone/changeset/internal/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package internal

import (
"context"
"errors"
"fmt"
"slices"
Expand Down Expand Up @@ -243,10 +242,10 @@ func NewRegisteredDon(env cldf.Environment, cfg RegisteredDonConfig) (*Registere
}

di, err := capReg.GetDONs(nil)
code, err2 := env.BlockChains.EVMChains()[cfg.RegistryChainSel].Client.CodeAt(context.TODO(), capReg.Address(), nil)
if err != nil {
return nil, fmt.Errorf("failed to get dons: %w, address: %s len code: %d err2: %w", err, capReg.Address(), len(code), err2)
return nil, fmt.Errorf("failed to get dons: %w, address: %s", err, capReg.Address())
}

// load the nodes from the offchain client
nodes, err := deployment.NodeInfo(cfg.NodeIDs, env.Offchain)
if err != nil {
Expand Down
Loading