Skip to content

update sui and fix tests#21867

Open
FelixFan1992 wants to merge 6 commits intodevelopfrom
fix-sui-tests-upgrade
Open

update sui and fix tests#21867
FelixFan1992 wants to merge 6 commits intodevelopfrom
fix-sui-tests-upgrade

Conversation

@FelixFan1992
Copy link
Copy Markdown
Contributor

Requires

Supports

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 4, 2026

CORA - Pending Reviewers

Codeowners Entry Overall Num Files Owners
* 1 @smartcontractkit/foundations, @smartcontractkit/core
/integration-tests/**/*ccip* 2 @smartcontractkit/ccip-offchain, @smartcontractkit/core, @smartcontractkit/ccip
/deployment/ccip/ 1 @smartcontractkit/ccip-tooling, @smartcontractkit/ccip-offchain, @smartcontractkit/operations-platform, @smartcontractkit/core
/.github/** 1 @smartcontractkit/devex-cicd, @smartcontractkit/devex-tooling, @smartcontractkit/core
go.mod 6 @smartcontractkit/core, @smartcontractkit/foundations
go.sum 6 @smartcontractkit/core, @smartcontractkit/foundations
integration-tests/go.mod 1 @smartcontractkit/core, @smartcontractkit/devex-tooling, @smartcontractkit/foundations
integration-tests/go.sum 1 @smartcontractkit/core, @smartcontractkit/devex-tooling, @smartcontractkit/foundations

Legend: ✅ Approved | ❌ Changes Requested | 💬 Commented | 🚫 Dismissed | ⏳ Pending | ❓ Unknown

For more details, see the full review summary.

@FelixFan1992 FelixFan1992 marked this pull request as ready for review April 4, 2026 19:26
Copilot AI review requested due to automatic review settings April 4, 2026 19:26
@FelixFan1992 FelixFan1992 requested review from a team as code owners April 4, 2026 19:26
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 4, 2026

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 4, 2026

✅ No conflicts with other open PRs targeting develop

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR bumps the github.com/smartcontractkit/chainlink-sui dependency (and related sums) across multiple Go modules in the repo, updates the public plugin pin for the Sui relayer, and adjusts CCIP Sui upgrade smoke tests to match the updated Sui changeset API.

Changes:

  • Update chainlink-sui (and in some modules chainlink-sui/deployment) pseudo-versions across root, deployment, integration-tests, system-tests, and scripts Go modules.
  • Update the Sui plugin gitRef in plugins/plugins.public.yaml.
  • Simplify BlockVersionConfig usage in ccip_sui_upgrade_test.go to align with the new config shape.

Reviewed changes

Copilot reviewed 9 out of 16 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
system-tests/tests/go.mod Bump chainlink-sui version in system test module.
system-tests/tests/go.sum Refresh sums for the updated chainlink-sui version.
system-tests/lib/go.mod Bump chainlink-sui version in system test library module.
system-tests/lib/go.sum Refresh sums for the updated chainlink-sui version.
plugins/plugins.public.yaml Update pinned Sui plugin gitRef used by loopinstall.
integration-tests/smoke/ccip/ccip_sui_upgrade_test.go Update Sui blocking changeset config to the new signature/fields.
integration-tests/load/go.mod Bump chainlink-sui and chainlink-sui/deployment versions for load tests module.
integration-tests/load/go.sum Refresh sums for updated Sui modules.
integration-tests/go.mod Bump chainlink-sui and chainlink-sui/deployment versions for integration tests module.
integration-tests/go.sum Refresh sums for updated Sui modules.
go.mod Bump top-level chainlink-sui dependency version.
go.sum Refresh sums for updated top-level chainlink-sui.
deployment/go.mod Bump chainlink-sui version used by deployment module.
deployment/go.sum Refresh sums for updated deployment module dependencies.
core/scripts/go.mod Bump chainlink-sui version used by scripts module.
core/scripts/go.sum Refresh sums for updated scripts module dependencies.

@@ -17,7 +17,7 @@ plugins:
- moduleURI: "github.com/smartcontractkit/chainlink-sui"
# IMP: consult chainlink-sui team before updating this version
# current version is v0.0.0-20260303203615-9d8cc32a70e7
Copy link

Copilot AI Apr 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The inline comment about the Sui plugin "current version" is now stale after updating gitRef. Please update or remove that comment so it reflects the pinned gitRef and doesn’t mislead future updates.

Suggested change
# current version is v0.0.0-20260303203615-9d8cc32a70e7
# current version is v0.0.0-20260404190644-86097f226a8f

Copilot uses AI. Check for mistakes.
@trunk-io
Copy link
Copy Markdown

trunk-io bot commented Apr 4, 2026

Static BadgeStatic BadgeStatic BadgeStatic Badge

Failed Test Failure Summary Logs
Test_CCIPTokenTransfer_EVM2Sui_BurnMintTokenPool/Send_token_to_EOA The test failed because an unexpected error occurred when trying to get the EVM fee, causing the transaction to revert. Logs ↗︎
Test_CCIPTokenTransfer_EVM2Sui_ManagedTokenPool_WithRateLimit The test failed due to an unspecified error during execution, with no clear indication of the specific issue from the provided logs. Logs ↗︎
Test_CCIPProgrammableTokenTransfer_EVM2Sui_BurnMintTokenPool The test failed because a required element or component was not found or did not respond as expected. Logs ↗︎
Test_CCIPTokenTransfer_EVM2Sui_BurnMintTokenPool The test failed without a specific error message, likely due to an unspecified issue during execution. Logs ↗︎

... and 6 more

View Full Report ↗︎Docs

@FelixFan1992 FelixFan1992 requested a review from a team as a code owner April 4, 2026 19:52
@FelixFan1992 FelixFan1992 requested review from a team as code owners April 4, 2026 22:25
@cl-sonarqube-production
Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants