Skip to content

fix: resolve two root causes of vrf v1 nightly race #22073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Fletch153 wants to merge 1 commit into from
+1 −7
Closed

fix: resolve two root causes of vrf v1 nightly race #22073

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions core/internal/cltest/cltest.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -631,6 +631,7 @@ func NewEthMocksWithStartupAssertions(t testing.TB) *clienttest.Client {
c.On("CodeAt", mock.Anything, mock.Anything, mock.Anything).Maybe().Return([]byte{}, nil)
c.On("NonceAt", mock.Anything, mock.Anything, mock.Anything).Maybe().Return(uint64(0), nil)
c.On("PendingNonceAt", mock.Anything, mock.Anything, mock.Anything).Maybe().Return(uint64(0), nil)
c.On("BalanceAt", mock.Anything, mock.Anything, mock.Anything).Maybe().Return(big.NewInt(0), nil)
Copy link
Copy Markdown
Contributor

@jmank88 jmank88 Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I thought we tried this? Don't some callers set it themselves with different values? Great if not though

c.On("Close").Maybe().Return()
c.On("BatchCallContext", mock.Anything, mock.Anything).Maybe().Return(nil)

Expand Down
7 changes: 0 additions & 7 deletions core/services/vrf/delegate_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,13 +198,6 @@ func setup(t *testing.T) (vrfUniverse, *v1.Listener, job.Job) {
require.NoError(t, err)
require.Len(t, vl, 1)
listener := vl[0].(*v1.Listener)
// Start the listenerV1
go func() {
listener.RunLogListener([]func(){}, 6)
}()
go func() {
listener.RunHeadListener(func() {})
}()
Comment on lines -201 to -207
Copy link
Copy Markdown
Contributor

@jmank88 jmank88 Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow, still passes?

servicetest.Run(t, listener)
return vuni, listener, jb
}
Expand Down
Loading