feat(cre-local): enable secrets management via vault don#22075
Merged
feat(cre-local): enable secrets management via vault don#22075
Conversation
Contributor
|
👋 czar0, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
Contributor
|
I see you updated files related to
|
Contributor
|
✅ No conflicts with other open PRs targeting |
Contributor
There was a problem hiding this comment.
Pull request overview
Risk Rating: HIGH
Enables CRE Local workflow deployments to manage secrets via the Vault DON by fetching the vault public key from the gateway, encrypting secrets locally, allowlisting the request in the workflow registry, and sending the encrypted payload to the gateway for vault storage.
Changes:
- Adds vault-secrets YAML parsing + encryption pipeline and a gateway JSON-RPC flow for public key fetch and secrets create.
- Updates deploy workflow CLI to accept
--gateway-urland to (optionally) update the vault capability config in the capabilities registry. - Adjusts example workflow deployment call to match the updated deploy function signature.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| core/scripts/cre/environment/environment/workflow.go | Implements vault gateway interactions, secrets encryption/output, allowlisting, and CLI flag changes for CRE Local secret management. |
| core/scripts/cre/environment/environment/examples.go | Updates example workflow deployment call to align with new deploy function parameters. |
|
|
- fix typo in secretsNamesConfig comment - add check for workflowRegistryVersion and capabilitiesRegistryVersion - allow more than 100 don via pagination - fetch vault capability id from helper - increase timeout for vault requests - return error value from sendToVaultGateway method
Tofel
reviewed
Apr 20, 2026
Tofel
reviewed
Apr 20, 2026
Tofel
reviewed
Apr 20, 2026
Tofel
reviewed
Apr 21, 2026
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Tofel
reviewed
Apr 21, 2026
Tofel
reviewed
Apr 21, 2026
Tofel
reviewed
Apr 21, 2026
Tofel
reviewed
Apr 23, 2026
Tofel
previously approved these changes
Apr 23, 2026
Tofel
approved these changes
Apr 23, 2026
|
cedric-cordenier
approved these changes
Apr 24, 2026
mchain0
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: this is for CRE Local only.
This pull request enables the CRE Local environment to manage secrets via the vault DON, as required by the current CRE architecture.
The workflows are registered and executed correctly, and the secrets are encrypted and fetched as shown in the log below.