Skip to content

core/services/ocr2/plugins/ocr2keeper/evmregistry/upkeepstate: fix test race; bump common to expose more races#22085

Merged
jmank88 merged 1 commit intodevelopfrom
race-fixes
Apr 20, 2026
Merged

core/services/ocr2/plugins/ocr2keeper/evmregistry/upkeepstate: fix test race; bump common to expose more races#22085
jmank88 merged 1 commit intodevelopfrom
race-fixes

Conversation

@jmank88
Copy link
Copy Markdown
Contributor

@jmank88 jmank88 commented Apr 20, 2026

@jmank88 jmank88 requested a review from pavel-raykov April 20, 2026 19:20
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 20, 2026

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 20, 2026 •
edited
Loading

✅ No conflicts with other open PRs targeting develop

@trunk-io
Copy link
Copy Markdown

trunk-io Bot commented Apr 20, 2026 •
edited
Loading

Static Badge   Static Badge   Static Badge   Static Badge

View Full Report ↗︎ ⋅ Docs

pavel-raykov
pavel-raykov previously approved these changes Apr 20, 2026
View reviewed changes
@jmank88 jmank88 dismissed pavel-raykov’s stale review April 20, 2026 20:18

The merge-base changed after approval.

@jmank88 jmank88 marked this pull request as ready for review April 20, 2026 20:18
@jmank88 jmank88 requested review from a team as code owners April 20, 2026 20:18
@jmank88 jmank88 requested review from Fletch153 and removed request for anirudhwarrier and gustavogama-cll April 20, 2026 20:19
@jmank88 jmank88 requested a review from pavel-raykov April 20, 2026 20:19
@jmank88 jmank88 enabled auto-merge April 20, 2026 20:20
@cl-sonarqube-production
Copy link
Copy Markdown

cl-sonarqube-production Bot commented Apr 20, 2026

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

@jmank88 jmank88 requested review from a team and Atrax1 April 20, 2026 22:40
@jmank88 jmank88 added this pull request to the merge queue Apr 20, 2026
Merged via the queue into develop with commit 20b000d Apr 20, 2026
213 checks passed
@jmank88 jmank88 deleted the race-fixes branch April 20, 2026 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patrickhuie19 patrickhuie19 patrickhuie19 approved these changes

@justinkaseman justinkaseman justinkaseman approved these changes

@Fletch153 Fletch153 Fletch153 approved these changes

@vyzaldysanchez vyzaldysanchez Awaiting requested review from vyzaldysanchez

@pavel-raykov pavel-raykov Awaiting requested review from pavel-raykov

@Atrax1 Atrax1 Awaiting requested review from Atrax1

@ibrajer ibrajer Awaiting requested review from ibrajer

@anirudhwarrier anirudhwarrier Awaiting requested review from anirudhwarrier

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jmank88 @patrickhuie19 @justinkaseman @Fletch153 @pavel-raykov