Conversation
CORA - Pending ReviewersAll codeowners have approved! ✅ Legend: ✅ Approved | ❌ Changes Requested | 💬 Commented | 🚫 Dismissed | ⏳ Pending | ❓ Unknown For more details, see the full review summary. |
|
✅ No conflicts with other open PRs targeting |
|
RensR
requested review from
0xAustinWang,
b-gopalswami,
chris-de-leon-cll,
makramkd,
matYang,
ogtownsend and
winder
product-security-plaid-production
Bot
requested review from
Tofel,
george-dorin,
giogam and
kdihalas
There was a problem hiding this comment.
Pull request overview
Risk Rating: MEDIUM (CI/test matrix + build tooling changes can silently reduce coverage)
Removes remaining references to the deprecated integration-tests/ccip-tests suite across build scripts, Docker image composition, docs, and CI configuration.
Changes:
- Remove
ccip-tests/*suite building/copying from the integration test Docker build flow. - Delete CCIP-specific test image build script/docs and remove legacy CCIP test matrix entries.
- Update ownership/docs/comments to drop
ccip-testsreferences.
Areas requiring scrupulous human review:
- CI trigger alignment between
.github/workflows/integration-tests.ymland.github/e2e-tests.yml(risk of running an empty test set on PR/merge-queue CCIP runs).
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| integration-tests/test.Dockerfile | Drops ccip-tests/load from default suites and stops copying ccip-tests binaries into the image. |
| integration-tests/scripts/buildTests | Removes special-case compilation/renaming for ccip-tests/load. |
| integration-tests/ccip-test-image-build.sh | Deletes CCIP test-image build helper script. |
| integration-tests/README.md | Removes CCIP 1.5 K8s test-image build/run documentation. |
| integration-tests/Makefile | Removes build-ccip-test-image target (leaving related image-push flow to reconcile). |
| deployment/environment/devenv/README.md | Removes ccip-tests-specific examples; adjusts references to testconfig. |
| deployment/ccip/changeset/cs_prerequisites.go | Removes comment referencing a now-removed ccip-tests helper constant. |
| .github/workflows/ccip-load-tests.yml | Deletes the CCIP load test workflow. |
| .github/e2e-tests.yml | Removes legacy integration-tests/ccip-tests/* entries from the runner test matrix. |
| .github/CODEOWNERS | Removes explicit ownership rule for /integration-tests/ccip-tests/. |
| copy the contents of [sepolia_avax_binance.toml](../../integration-tests/testconfig/ccip/overrides/sepolia_avax_binance.toml) | ||
| to the `overrides.toml` file. |
There was a problem hiding this comment.
This relative link appears to be incorrect from deployment/environment/devenv/README.md (there is no deployment/integration-tests directory). It should likely point to ../../../integration-tests/testconfig/ccip/overrides/sepolia_avax_binance.toml so the documentation link works.
| # base-image-registry: AWS registry (only secure-sdlc account works) | ||
| # check AWS Portal and search for | ||
| # <image_registry> | secure-sdlc@smartcontract.com |
There was a problem hiding this comment.
This CCIP test-image registry comment block now precedes only a push target (push-ccip-test-image) while the corresponding build target/script were removed in this PR. As-is, the remaining flow is incomplete (it assumes chainlink-tests:latest exists) and is no longer documented; consider removing the push target too, or reintroducing a supported build+push workflow.
No description provided.