[CRE-3674] fix: flaky Test_RegistrySynchronizer1_3_UpkeepCheckDataUpdatedLog#22126
Open
[CRE-3674] fix: flaky Test_RegistrySynchronizer1_3_UpkeepCheckDataUpdatedLog#22126
Conversation
Add initial check data verification before proceeding to the log handling phase, matching the pattern used in the stable UpkeepGasLimitSetLog test. This ensures fullSync has fully completed and the run loop is in the select statement before the test sets up new mocks and calls HandleLog. Also remove unused broadcast mock. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
aareet
force-pushed
the
fix/flaky-TestSyncer-UpkeepCheckDataUpdatedLog
branch
from
16346e4 to
bfc72f4
Compare
Contributor
|
✅ No conflicts with other open PRs targeting |
aareet
changed the title
|
ibrajer
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
g.Eventually) before the log handling phase to ensurefullSynchas fully completed and the run loop is in theselectstatement — matches the pattern used in the stableUpkeepGasLimitSetLogtestlogmocks.NewBroadcast(t)(dead code)Fixes: CRE-3674
Root cause
WaitForCountsucceeds as soon asUpsertUpkeepcommits, butfullSyncmay still be running (goroutines inbatchSyncUpkeepsOnRegistryhaven't finished). Under CI load, this delays when the run loop entersselectand picks up the log notification fromHandleLog, causing the test to hang or fail.Test plan
go test -race -count=5 -run Test_RegistrySynchronizer1_3_UpkeepCheckDataUpdatedLog— 5/5 passes🤖 Generated with Claude Code