Skip to content

ignore SLOW SQL QUERY critical log in all log poller tests #22128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tofel merged 2 commits into from
Apr 22, 2026
+14 −14
Merged

ignore SLOW SQL QUERY critical log in all log poller tests #22128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
730f509
ignore SLOW SQL QUERY critical log in all log poller tests
Tofel Apr 22, 2026
59a7f4f
do not call t.Errorf
Tofel Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion devenv/tests/automation/load_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@ func TestLoad(t *testing.T) {
},
},
)
t.Error("failed to scan Docker container logs:", scanErr)

if t.Failed() {
saveErr := framework.StreamCTFContainerLogsFanout(
Expand Down
26 changes: 14 additions & 12 deletions devenv/tests/logpoller/logpoller_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,13 @@ import (
"github.com/smartcontractkit/chainlink/devenv/products/automation"
)

var ignoredSlowQueryLog = products.NewAllowedLogMessage(
"SLOW SQL QUERY",
"It is expected, because we are pausing the Postgres container",
zapcore.DPanicLevel,
products.WarnAboutAllowedMsgs_No,
)

// consistency test with no network disruptions with approximate emission of 1500-1600 logs per second for ~110-120 seconds
// 6 filters are registered

Expand All @@ -45,7 +52,7 @@ func TestLogPoller(t *testing.T) {
MaxEmitWaitTimeMs: 600,
},
}
executePollerTest(t, cfg)
executePollerTest(t, cfg, ignoredSlowQueryLog)
}

// consistency test that registers filters after events were emitted and then triggers replay via API
Expand All @@ -69,7 +76,7 @@ func TestLogPollerReplay(t *testing.T) {
MaxEmitWaitTimeMs: 600,
},
}
executeLogPollerReplay(t, cfg, "5m")
executeLogPollerReplay(t, cfg, "5m", ignoredSlowQueryLog)
}

// TODO: adjust these values to what we are/can really run, they seem to be outdated
Expand All @@ -93,7 +100,7 @@ func XTestLogPollerHeavyLoad(t *testing.T) {
},
}

executePollerTest(t, cfg)
executePollerTest(t, cfg, ignoredSlowQueryLog)
}

// consistency test that introduces random disruptions by pausing Chainlink containers for random interval of 5-20 seconds
Expand All @@ -120,7 +127,7 @@ func TestLogPollerChaosChainlinkNodes(t *testing.T) {
},
}

executePollerTest(t, cfg)
executePollerTest(t, cfg, ignoredSlowQueryLog)
}

// consistency test that introduces random disruptions by pausing Postgres container for random interval of 5-20 seconds
Expand All @@ -147,12 +154,7 @@ func TestLogPollerChaosPostgres(t *testing.T) {
},
}

executePollerTest(t, cfg, products.NewAllowedLogMessage(
"SLOW SQL QUERY",
"It is expected, because we are pausing the Postgres container",
zapcore.DPanicLevel,
products.WarnAboutAllowedMsgs_No,
))
executePollerTest(t, cfg, ignoredSlowQueryLog)
}

func executePollerTest(t *testing.T, cfg *Config, allowedLogMessages ...products.AllowedLogMessage) {
Expand Down Expand Up @@ -311,7 +313,7 @@ func executePollerTest(t *testing.T, cfg *Config, allowedLogMessages ...products
waitUntilNodesHaveTheSameLogsAsEvm(l, nil, t, allNodesLogCountMatches, lpTestEnv, cfg, startBlock, endBlock, "5m")
}

func executeLogPollerReplay(t *testing.T, cfg *Config, consistencyTimeout string) {
func executeLogPollerReplay(t *testing.T, cfg *Config, consistencyTimeout string, allowedLogMessages ...products.AllowedLogMessage) {
outputFile := "../../env-out.toml"
in, err := de.LoadOutput[de.Cfg](outputFile)
Comment thread
Tofel marked this conversation as resolved.
require.NoError(t, err)
Expand All @@ -326,7 +328,7 @@ func executeLogPollerReplay(t *testing.T, cfg *Config, consistencyTimeout string
l := framework.L
ctx := t.Context()
t.Cleanup(func() {
cleanupErr := products.CleanupContainerLogs(products.DefaultSettings())
cleanupErr := products.CleanupContainerLogs(products.DefaultSettings(allowedLogMessages...))
require.NoError(t, cleanupErr, "failed to process cleanup container logs")
})

Expand Down
1 change: 0 additions & 1 deletion devenv/tests/ocr2/soak_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ func TestOCR2Soak(t *testing.T) {
},
},
)
t.Error("failed to scan Docker container logs:", scanErr)

if t.Failed() {
saveErr := framework.StreamCTFContainerLogsFanout(
Expand Down
Loading