fix: add waitDeployed to BundleAggregatorProxy deployments#22129
fix: add waitDeployed to BundleAggregatorProxy deployments#22129karen-stepanyan merged 3 commits intodevelopfrom
Conversation
|
👋 cll-dawid, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
|
✅ No conflicts with other open PRs targeting |
There was a problem hiding this comment.
Pull request overview
Risk Rating: MEDIUM — changes the deployment confirmation mechanism for an on-chain contract deployment path.
This PR aims to make BundleAggregatorProxy deployments wait until the contract is actually deployed (and code exists) by switching from the framework’s chain.Confirm + manual receipt/code checks to bind.WaitDeployed.
Changes:
- Replaced
chain.Confirm(tx)+ explicit receipt/code verification withbind.WaitDeployed(...)forDeployBundleAggregatorProxy. - Updated logging and address-mismatch handling to use the deployed address returned by
WaitDeployed.
Scrupulous human review focus:
- The behavioral difference between
cldf_evm.Chain.Confirm(tx)andbind.WaitDeployed(...)(confirmation depth/retry semantics, consistency across deployments). - Whether the PR’s stated scope (“proxy deployments”) should also include
DeployAggregatorProxy(and/or other deployment paths) for consistent behavior.
|




Requires
Supports