Skip to content

fix: add waitDeployed to BundleAggregatorProxy deployments#22129

Merged
karen-stepanyan merged 3 commits intodevelopfrom
fix/deploy-bundle-proxy-wait-deployed
Apr 22, 2026
Merged

fix: add waitDeployed to BundleAggregatorProxy deployments#22129
karen-stepanyan merged 3 commits intodevelopfrom
fix/deploy-bundle-proxy-wait-deployed

Conversation

@cll-dawid
Copy link
Copy Markdown
Contributor

Requires

Supports

Copilot AI review requested due to automatic review settings April 22, 2026 10:37
@cll-dawid cll-dawid requested review from a team as code owners April 22, 2026 10:37
@cll-dawid cll-dawid changed the title fix: add waitDeployed to proxy deployments fix: add waitDeployed to BundleAggregatorProxy deployments Apr 22, 2026
@github-actions
Copy link
Copy Markdown
Contributor

👋 cll-dawid, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 22, 2026

✅ No conflicts with other open PRs targeting develop

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Risk Rating: MEDIUM — changes the deployment confirmation mechanism for an on-chain contract deployment path.

This PR aims to make BundleAggregatorProxy deployments wait until the contract is actually deployed (and code exists) by switching from the framework’s chain.Confirm + manual receipt/code checks to bind.WaitDeployed.

Changes:

  • Replaced chain.Confirm(tx) + explicit receipt/code verification with bind.WaitDeployed(...) for DeployBundleAggregatorProxy.
  • Updated logging and address-mismatch handling to use the deployed address returned by WaitDeployed.

Scrupulous human review focus:

  • The behavioral difference between cldf_evm.Chain.Confirm(tx) and bind.WaitDeployed(...) (confirmation depth/retry semantics, consistency across deployments).
  • Whether the PR’s stated scope (“proxy deployments”) should also include DeployAggregatorProxy (and/or other deployment paths) for consistent behavior.

Comment thread deployment/data-feeds/changeset/deploy.go
Comment thread deployment/data-feeds/changeset/deploy.go
@trunk-io
Copy link
Copy Markdown

trunk-io Bot commented Apr 22, 2026

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

@cl-sonarqube-production
Copy link
Copy Markdown

@karen-stepanyan karen-stepanyan added this pull request to the merge queue Apr 22, 2026
Merged via the queue into develop with commit 7e5e991 Apr 22, 2026
206 checks passed
@karen-stepanyan karen-stepanyan deleted the fix/deploy-bundle-proxy-wait-deployed branch April 22, 2026 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants