Skip to content

fix: add manual check with retry logic to BundleAggregatorProxy deployments tx receipt#22136

Merged
karen-stepanyan merged 7 commits intodevelopfrom
fix/deploy-bundle-proxy-wait-deployed
Apr 22, 2026
Merged

fix: add manual check with retry logic to BundleAggregatorProxy deployments tx receipt#22136
karen-stepanyan merged 7 commits intodevelopfrom
fix/deploy-bundle-proxy-wait-deployed

Conversation

@cll-dawid
Copy link
Copy Markdown
Contributor

Requires

Supports

@cll-dawid cll-dawid requested a review from a team as a code owner April 22, 2026 16:52
Copilot AI review requested due to automatic review settings April 22, 2026 16:52
@cll-dawid cll-dawid requested review from a team as code owners April 22, 2026 16:52
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 22, 2026

✅ No conflicts with other open PRs targeting develop

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Risk Rating: MEDIUM

This PR hardens data-feeds contract deployment verification by replacing bind.WaitDeployed / single CodeAt checks with a bounded retry loop that waits for contract code to appear after the deployment tx is confirmed (notably for BundleAggregatorProxy).

Changes:

  • Introduces waitForContractCode using a capped Fibonacci backoff with a 90s max duration.
  • Uses the new helper to verify deployments for DataFeedsCache, AggregatorProxy, and BundleAggregatorProxy.
  • Adjusts BundleAggregatorProxy “code verified” logging fields.
Comments suppressed due to low confidence (1)

deployment/data-feeds/changeset/deploy.go:168

  • The debug log for the successful BundleAggregatorProxy deployment verification no longer includes the txHash (and previously included codeSize). Keeping txHash in this log line is useful for tracing deployments in RPC/indexer issues, and it’s still available as tx.Hash() even if you no longer log code size.
	proxyContract, err := bundleproxy.NewBundleAggregatorProxy(proxyAddr, chain.Client)
	if err != nil {
		return nil, fmt.Errorf("failed to bind BundleAggregatorProxy at %s: %w", proxyAddr, err)

Comment thread deployment/data-feeds/changeset/deploy.go
@trunk-io
Copy link
Copy Markdown

trunk-io Bot commented Apr 22, 2026

Static BadgeStatic BadgeStatic BadgeStatic Badge

Failed Test Failure Summary Logs
Test_CCIPTokenTransfer_EVM2Sui_BurnMintTokenPool The test failed during a token transfer operation, but the specific cause of failure is not detailed in the log. Logs ↗︎

View Full Report ↗︎Docs

@cl-sonarqube-production
Copy link
Copy Markdown

@karen-stepanyan karen-stepanyan added this pull request to the merge queue Apr 22, 2026
Merged via the queue into develop with commit 9a878bf Apr 22, 2026
203 of 206 checks passed
@karen-stepanyan karen-stepanyan deleted the fix/deploy-bundle-proxy-wait-deployed branch April 22, 2026 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants