[DO NOT MERGE] Disable Solana non-LOOP mode by huangzhen1997 · Pull Request #22139 · smartcontractkit/chainlink

huangzhen1997 · 2026-04-22T21:06:13Z

Jira: https://smartcontract-it.atlassian.net/browse/NONEVM-4683

Prerequisite: Chainlink-solana raw config smartcontractkit/chainlink-solana#1541

Similar to Cosmos/Starnet transformation, Solana now will run exclusively as a LOOP plugin, matching every other non-EVM chain in the codebase.

NewSolana drops the non-LOOP mode fallback. It now resolves the plugin command like every other LOOP relayer
(cmp.Or(env.SolanaPlugin.Cmd.Get(), env.SolanaPlugin.CmdDefault)) and fails fast if empty. There's a next step to refactor the solana config so we can invoke NewLOOPRelayer directly, and remove Solana codec by importing from chainlink-solana
Test refactors:
- Solana-specific tests (CLI, HTTP controllers, replay) moved behind //go:build integration, as they need the relayer binary. Placed alongside other LOOP-only nonEVM family.
- Deleted testdata/scripts/health/multi-chain.txtar, it was the embedded variant of multi-chain-loopp.txtar, which already covers the LOOP case.
- TestCoreRelayerChainInteroperators skips Solana the same way it already skipped Aptos/Tron/TON/Sui, since LOOP-only chains aren't exercised at this level.

github-actions · 2026-04-22T21:06:32Z

👋 huangzhen1997, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

github-actions · 2026-04-22T21:07:25Z

✅ No conflicts with other open PRs targeting develop

github-actions · 2026-04-22T21:07:29Z

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

#added For any new functionality added.
#breaking_change For any functionality that requires manual action for the node to boot.
#bugfix For bug fixes.
#changed For any change to the existing functionality.
#db_update For any feature that introduces updates to database schema.
#deprecation_notice For any upcoming deprecation functionality.
#internal For changesets that need to be excluded from the final changelog.
#nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
#removed For any functionality/config that is removed.
#updated For any functionality that is updated.
#wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

Copilot

Pull request overview

Risk Rating: HIGH — changes the Solana relayer instantiation path in a core factory and removes the embedded (non-LOOP) fallback, which can materially affect runtime behavior and deploy configuration expectations.

This PR removes the ability to run Solana in embedded (non-LOOP) mode and updates the relayer factory to always create Solana relayers via a LOOP plugin.

Changes:

Removes the embedded Solana chain fallback and always constructs a LOOP relayer for each enabled Solana chain.
Hardcodes the Solana plugin command to chainlink-solana and keeps env-file parsing for plugin env vars.

Human review focus:

Configuration/feature-gating implications of ignoring CL_SOLANA_CMD (and consistency with other Solana plugin “supported” checks).
Runtime behavior when the chainlink-solana binary is not present or when env-file settings differ across deployments.

trunk-io · 2026-04-22T21:26:33Z

Failed Test	Failure Summary	Logs
`TestConfigPoller`	The test failed due to an 'underpriced replacement transaction' error during contract deployment, and it was marked as a known flaky test that ran...	Logs ↗︎

_{View Full Report ↗︎ ⋅ Docs}

huangzhen1997 · 2026-04-24T21:15:11Z

        -- -v -run "Test_CCIPMessaging_EVM2EVM" -timeout 18m -count=1 -parallel=4 ./smoke/ccip
    test_go_project_path: integration-tests

-  - id: smoke/ccip/ccip_messaging_test.go:Test_CCIPMessaging_EVM2Solana


Remove the NON-LOOP in-process Solana e2e testcase. The LOOP supported is kept below.

huangzhen1997 · 2026-04-24T21:16:24Z

 	assertTableRenders(t, r)
 }
-
-func TestShell_IndexSolanaChains(t *testing.T) {


Moved to a different file core/cmd/chains_commands_integration_test.go where we run it with //go:build integration to enable LOOP

huangzhen1997 · 2026-04-24T21:17:48Z

 	assert.Contains(t, renderLines[14], n2.State)
 }

-func solanaStartNewApplication(t *testing.T, cfgs ...*solcfg.TOMLConfig) *cltest.TestApplication {


Same as here. Moved to core/cmd/node_commands_integration_test.go.

huangzhen1997 · 2026-04-24T21:20:04Z

 	}
 }

-func Test_SolanaChainsController_Show(t *testing.T) {


Same idea, moved to different file to run with LOOP

huangzhen1997 · 2026-04-24T23:49:58Z

@@ -0,0 +1,33 @@
+//go:build integration
+
+package cmd_test


Moved from core/cmd/blocks_commands_test.go

huangzhen1997 · 2026-04-25T00:01:42Z

 	assertTableRenders(t, r)
 }
+
+func TestShell_IndexSolanaChains(t *testing.T) {


Moved from core/cmd/shell_remote_test.go

huangzhen1997 · 2026-04-25T17:12:34Z

Is the config the only remaining source of solana imports? Rather than Ton, consider using starknet or cosmos for inspiration, since they went through the same transformation, while Ton was never embedded.

Besides solana config, I have another branch in progress that removes the codec in core and import it from chain specific repo, like TON does.

github-actions · 2026-04-25T20:07:31Z

CORA - Pending Reviewers

Codeowners Entry	Overall	Num Files	Owners
`*`	💬	33	@smartcontractkit/foundations, @smartcontractkit/core
`/core/capabilities/ccip/ccipsolana/`	💬	1	@smartcontractkit/bix-build
`/core/web/resolver/`	💬	3	@smartcontractkit/foundations, @smartcontractkit/core
`/deployment/`	💬	1	@smartcontractkit/ccip-tooling, @smartcontractkit/ccip-offchain, @smartcontractkit/keystone, @smartcontractkit/operations-platform, @smartcontractkit/core
`/.github/**`	💬	1	@smartcontractkit/devex-cicd, @smartcontractkit/devex-tooling, @smartcontractkit/core
`go.mod`	💬	6	@smartcontractkit/core, @smartcontractkit/foundations
`go.sum`	💬	6	@smartcontractkit/core, @smartcontractkit/foundations
`integration-tests/go.mod`	💬	1	@smartcontractkit/core, @smartcontractkit/devex-tooling, @smartcontractkit/foundations
`integration-tests/go.sum`	💬	1	@smartcontractkit/core, @smartcontractkit/devex-tooling, @smartcontractkit/foundations

For more details, see the full review summary.

cl-sonarqube-production · 2026-04-26T16:44:57Z

Quality Gate passed

Issues
0 New issues
22 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

huangzhen1997 · 2026-04-26T16:47:10Z

    test_go_project_path: integration-tests
    install_plugins_public: true
-    test_env_vars:
-      CL_SOLANA_CMD: chainlink-solana


NewLOOPRelayer() now uses plugin default value

huangzhen1997 · 2026-04-26T16:47:46Z

 		ChainRW:                    ChainRWProvider{},
 		ExtraDataCodec:             ExtraDataDecoder{},
 		PriceOnlyCommitFn:          consts.MethodCommitPriceOnly,
-		CCIPProviderSupported:      env.SolanaPlugin.Cmd.Get() != "",


LOOP mode only, so CCIP provide always supported

archseer · 2026-04-27T06:03:14Z

        --format=github-actions \
        -- -v -run "^TestRMNCurse$" -timeout 20m -count=1 -parallel=4 smoke/ccip/ccip_cs_rmn_curse_uncurse_test.go
    test_go_project_path: integration-tests
+    install_plugins_public: true


Is this really necessary? It's testing against EVM?

archseer · 2026-04-27T06:03:25Z

        --format=github-actions \
        -- -v -run "^TestRMNCurseIdempotent$" -timeout 20m -count=1 -parallel=4 smoke/ccip/ccip_cs_rmn_curse_uncurse_test.go
    test_go_project_path: integration-tests
+    install_plugins_public: true


Same for all these other tests

archseer · 2026-04-27T06:03:58Z

 	lggr := logger.TestLogger(t)
 	reg := plugins.NewTestLoopRegistry(lggr)
-	ks := &keystore.StarknetLooppSigner{StarkNet: mocks.NewStarkNet(t)}
+	ks := &keystore.SolanaLooppSigner{Solana: mocks.NewSolana(t)}


Nice catch :)

archseer · 2026-04-27T06:04:29Z

@@ -619,78 +619,78 @@ HTTPURL = 'http://broadcast.mirror'
 SendOnly = true

 [[Solana]]


Hmm why are all these configs changed?

step 1, remove option for non-LOOP mode

dcd8218

Copilot AI review requested due to automatic review settings April 22, 2026 21:06

huangzhen1997 requested review from a team as code owners April 22, 2026 21:06

product-security-plaid-production Bot requested a review from pavel-raykov April 22, 2026 21:06

huangzhen1997 changed the title ~~step 1, remove option for non-LOOP mode~~ Remove option for non-LOOP mode Apr 22, 2026

Copilot started reviewing on behalf of huangzhen1997 April 22, 2026 21:07 View session

Copilot AI reviewed Apr 22, 2026

View reviewed changes

Comment thread core/services/chainlink/relayer_factory.go Outdated

Comment thread core/services/chainlink/relayer_factory.go Outdated

Comment thread core/services/chainlink/relayer_factory.go Outdated

huangzhen1997 changed the title ~~Remove option for non-LOOP mode~~ Disable Solana non-LOOP mode Apr 22, 2026

huangzhen1997 marked this pull request as draft April 22, 2026 21:28

huangzhen1997 requested a review from archseer April 23, 2026 01:39

huangzhen1997 added 5 commits April 23, 2026 17:30

do not use hard coded cmd

557abdf

rm non-LOOPP solana e2e test

c6f0a3c

update CI

0bd92fd

add Solana loop for failing test

2dc6c1b

refactor solana core test into integration with LOOP plugin

ca14ec0

huangzhen1997 commented Apr 24, 2026

View reviewed changes

huangzhen1997 added 3 commits April 24, 2026 16:33

refactor test

ac8c35e

fix lint

229e097

move refactor and remove solana from non-loop health report

9752a12

huangzhen1997 changed the title ~~Disable Solana non-LOOP mode~~ Disable Solana non-LOOP mode Apr 24, 2026

huangzhen1997 commented Apr 24, 2026

View reviewed changes

huangzhen1997 commented Apr 25, 2026

View reviewed changes

huangzhen1997 added 2 commits April 25, 2026 14:51

test: align solana interoperator test with cosmos/starknet pattern

2130f0d

refactor solana relay config to use raw unwrapped

b220ea4

huangzhen1997 requested review from a team as code owners April 25, 2026 20:07

huangzhen1997 requested review from 0xAustinWang, b-gopalswami, carte7000, makramkd, matYang, ogtownsend and winder April 25, 2026 20:07

product-security-plaid-production Bot requested a review from graham-chainlink April 25, 2026 20:07

huangzhen1997 added 6 commits April 25, 2026 15:30

mod tidy

bbd0f3e

fix test

7ae63ea

use default cmd

d8987cc

fix

08fec60

fix test

6678156

add test env var back

bc5f211

huangzhen1997 mentioned this pull request Apr 26, 2026

un-nest Solana config + validate and setDefault smartcontractkit/chainlink-solana#1541

Open

update yml again with plugin fix

df8c4a9

huangzhen1997 requested a review from a team as a code owner April 26, 2026 16:09

huangzhen1997 changed the title ~~Disable Solana non-LOOP mode~~ [DO NOT MERGE] Disable Solana non-LOOP mode Apr 26, 2026

huangzhen1997 commented Apr 26, 2026

View reviewed changes

archseer reviewed Apr 27, 2026

View reviewed changes

		@@ -619,78 +619,78 @@ HTTPURL = 'http://broadcast.mirror'
		SendOnly = true

		[[Solana]]

Conversation

huangzhen1997 commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Apr 22, 2026

Uh oh!

github-actions Bot commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Apr 22, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

trunk-io Bot commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

huangzhen1997 Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

huangzhen1997 Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

huangzhen1997 commented Apr 25, 2026

Uh oh!

github-actions Bot commented Apr 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CORA - Pending Reviewers

Uh oh!

cl-sonarqube-production Bot commented Apr 26, 2026

Quality Gate passed

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

huangzhen1997 commented Apr 22, 2026 •

edited

Loading

github-actions Bot commented Apr 22, 2026 •

edited

Loading

trunk-io Bot commented Apr 22, 2026 •

edited

Loading

huangzhen1997 Apr 24, 2026 •

edited

Loading

huangzhen1997 Apr 24, 2026 •

edited

Loading

github-actions Bot commented Apr 25, 2026 •

edited

Loading