chore: remove link token and static link token view functions and uses#22151
Draft
chore: remove link token and static link token view functions and uses#22151
Conversation
… cld-changesets instead
Contributor
CORA - Pending Reviewers
Legend: ✅ Approved | ❌ Changes Requested | 💬 Commented | 🚫 Dismissed | ⏳ Pending | ❓ Unknown For more details, see the full review summary. |
Contributor
|
✅ No conflicts with other open PRs targeting |
Contributor
There was a problem hiding this comment.
Pull request overview
Risk Rating: MEDIUM — shifts LINK token view generation to an external module and bumps several deployment dependencies, which may affect downstream serialization/contracts tooling.
This PR migrates LINK and static LINK token view generation out of this repo (from deployment/common/view/v1_0) to github.com/smartcontractkit/cld-changesets, updating state/view call sites accordingly.
Changes:
- Remove in-repo
LinkTokenView/StaticLinkTokenViewimplementations and their unit tests underdeployment/common/view/v1_0. - Update EVM changeset state helpers and CCIP chain view structs to use
cld-changesets/pkg/contract/link/view/v1_0. - Add
github.com/smartcontractkit/cld-changesetstodeployment/go.modand update related dependency versions indeployment/go.mod/deployment/go.sum.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| deployment/go.mod | Adds cld-changesets dependency and bumps several deployment-related modules. |
| deployment/go.sum | Records new module checksums for the updated/added dependencies. |
| deployment/common/view/v1_0/link_token.go | Removes local LINK token view generation implementation. |
| deployment/common/view/v1_0/link_token_test.go | Removes local LINK token view unit test. |
| deployment/common/view/v1_0/static_link_token.go | Removes local static LINK token view generation implementation. |
| deployment/common/view/v1_0/static_link_token_test.go | Removes local static LINK token view unit test. |
| deployment/common/changeset/state/evm.go | Switches LINK/static LINK view generation to cld-changesets types/functions. |
| deployment/common/changeset/state.go | Switches deprecated LINK/static LINK view helpers to cld-changesets types/functions. |
| deployment/ccip/view/view.go | Changes ChainView LINK/static LINK fields to cld-changesets view types. |
Contributor
|
I see you updated files related to
|
ecPablo
changed the title
|
|
Co-authored-by: vicentevieytes <73846744+vicentevieytes@users.noreply.github.com>
# Conflicts: # deployment/go.mod # integration-tests/go.mod # integration-tests/load/go.mod # system-tests/lib/go.mod
# Conflicts: # integration-tests/go.sum # integration-tests/load/go.sum
| require.NoError(t, err, "failed to get TON commit sha") | ||
| // TODO replace the hardcoded commit sha with the one fetched from memory.GetTONSha() | ||
| contractVersion := "054376f21418" // https://github.com/smartcontractkit/chainlink-ton/releases/tag/ton-contracts-build-054376f21418 | ||
| contractVersion := "github.com/smartcontractkit/chainlink-ton@contracts/1.6.0" |
Collaborator
There was a problem hiding this comment.
Is this correct, the previous version was 054376f21418 ? Should we be using the hash?
Contributor
Author
There was a problem hiding this comment.
Yes, this was shared by @vicentevieytes #22151 (comment) to upgrade contracts to a tagged version where some breaking changes are fixed.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are moving the code in
deployment/commonto CLDF andcld-changesets. This PR removes usages for link and static link token state functions and removes the files from the repo in favor of importing them fromcld-changesets