Skip to content

LLO: Fix buffered telemetry sampling #22548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akuzni2 merged 3 commits into from
May 26, 2026
Merged

LLO: Fix buffered telemetry sampling #22548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
46e144f
fix buffered telemetry sampling
calvwang9 May 20, 2026
0f8d3f1
add changeset
calvwang9 May 20, 2026
8ad062a
Merge branch 'develop' of github.com:smartcontractkit/chainlink into …
calvwang9 May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/weak-pandas-draw.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"chainlink": patch
---

#bugfix fix llo buffered telemetry sampling
27 changes: 15 additions & 12 deletions core/services/llo/telem/telemetry.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,6 +302,10 @@ func (t *telemeter) sendBufferedTelemetry(digest types.ConfigDigest, seqNr uint6
go func() {
for _, msgs := range messages {
for _, msg := range msgs {
// Sampling is applied at flush time (not enqueue time) for buffered telemetry
if !t.sampler.Sample(msg.telemType, msg.msg) {
continue
}
bytes, err := proto.Marshal(msg.msg)
if err != nil {
t.eng.Warnf("protobuf marshal failed %v", err.Error())
Expand Down Expand Up @@ -337,12 +341,12 @@ func (t *telemeter) enqueueTelemetry(digest string, seqNr uint64, typ synchroniz
if _, ok := t.telemetryBuffer[digest]; !ok {
t.telemetryBuffer[digest] = make(map[uint64][]telemetryEntry)
}
if t.sampler.Sample(typ, msg) {
t.telemetryBuffer[digest][seqNr] = []telemetryEntry{{
telemType: typ,
msg: msg,
}}
}

// Sampling is applied at flush time for buffered telemetry
t.telemetryBuffer[digest][seqNr] = []telemetryEntry{{
telemType: typ,
msg: msg,
}}
default: // synchronization.LLOReport and other buffered types
// Report telemetry: append, since multiple reports per seqNr is
// expected (one per reportable channel).
Expand All @@ -352,12 +356,11 @@ func (t *telemeter) enqueueTelemetry(digest string, seqNr uint64, typ synchroniz
if _, ok := t.telemetryBuffer[digest]; !ok {
t.telemetryBuffer[digest] = make(map[uint64][]telemetryEntry)
}
if t.sampler.Sample(typ, msg) {
t.telemetryBuffer[digest][seqNr] = append(t.telemetryBuffer[digest][seqNr], telemetryEntry{
telemType: typ,
msg: msg,
})
}
// Sampling is applied at flush time for buffered telemetry
t.telemetryBuffer[digest][seqNr] = append(t.telemetryBuffer[digest][seqNr], telemetryEntry{
telemType: typ,
msg: msg,
})
Comment on lines 345 to +363

@akuzni2 akuzni2 May 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree can we consider adding this @calvwang9 ?

}
}

Expand Down
Loading
Loading