Skip to content

Add privacy as CODEOWNER for confidentialrelay paths in core#22762

Merged
pavel-raykov merged 3 commits into
developfrom
tejaswi/codeowners-confidentialrelay
Jun 10, 2026
Merged

Add privacy as CODEOWNER for confidentialrelay paths in core#22762
pavel-raykov merged 3 commits into
developfrom
tejaswi/codeowners-confidentialrelay

Conversation

@nadahalli

@nadahalli nadahalli commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

The confidentialrelay code (relay-DON authorization logic, PRIV-433, PRIV-458) is privacy-owned security code spread across three paths, none of which had a privacy CODEOWNERS entry:

  • /core/capabilities/confidentialrelay/ (inherited /core/capabilities/ -> keystone + capabilities-team)
  • /core/services/gateway/handlers/confidentialrelay/
  • /system-tests/lib/cre/features/confidentialrelay/

Privacy could not approve changes there as a code owner (e.g. #22516, #22703). This adds @smartcontractkit/privacy for all three.

Note: GitHub only honors these entries if the @smartcontractkit/privacy team has write access to this repo. https://smartcontract-it.atlassian.net/servicedesk/customer/portal/4/SECHD-31726

confidentialrelay holds the relay-DON authorization logic (PRIV-433, PRIV-458),
which is privacy-owned security code. It currently inherits /core/capabilities/
(keystone + capabilities-team) with no privacy entry. Add privacy alongside the
existing owners so privacy can review and approve changes there, e.g. #22516
and #22703.
@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Thank you for adding a CODEOWNERS file - @nadahalli.

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

👋 nadahalli, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

✅ No conflicts with other open PRs targeting develop

Both confidentialrelay paths are purely privacy's confidential-relay code:
the capability handler (core/capabilities/confidentialrelay) and the gateway
handler (core/services/gateway/handlers/confidentialrelay). Assign both to
@smartcontractkit/privacy outright, mirroring confidentialhttp in chainlink-common.
@nadahalli nadahalli changed the title Add privacy as CODEOWNER for core/capabilities/confidentialrelay Add privacy as CODEOWNER for core/capabilities/confidentialrelay and /core/services/gateway/handlers/confidentialrelay/ Jun 9, 2026
@nadahalli nadahalli changed the title Add privacy as CODEOWNER for core/capabilities/confidentialrelay and /core/services/gateway/handlers/confidentialrelay/ Add privacy as CODEOWNER for confidentialrelay paths in core Jun 9, 2026
@pavel-raykov pavel-raykov added this pull request to the merge queue Jun 10, 2026
Merged via the queue into develop with commit 91ee778 Jun 10, 2026
71 of 72 checks passed
@pavel-raykov pavel-raykov deleted the tejaswi/codeowners-confidentialrelay branch June 10, 2026 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants