tests: replace legacy changeset usage with new

Replace legacy changeset usage in the new changeset tests , spefiically the deploy mcms legacy changeset, now they use the new deploy changeset for mcms

Author: graham-chainlink

internal/testutil/solanatest/datastore.go

@@ -0,0 +1,39 @@
+// Package solanatest provides test utilities for Solana MCMS integration tests.
+package solanatest
+
+import (
+	"testing"
+
+	"github.com/smartcontractkit/chainlink-deployments-framework/datastore"
+	mcmscontracts "github.com/smartcontractkit/chainlink-deployments-framework/engine/cld/contracts/mcms"
+	"github.com/stretchr/testify/require"
+
+	"github.com/smartcontractkit/cld-changesets/internal/semvers"
+	"github.com/smartcontractkit/cld-changesets/legacy/pkg/family/solana/solutils"
+)
+
+// PreloadDatastoreWithMCMSPrograms seeds a datastore with canonical MCMS program IDs
+// for the given chain selector. Use with the mcms/changesets/deploy changeset.
+func PreloadDatastoreWithMCMSPrograms(t *testing.T, selector uint64) datastore.DataStore {
+	t.Helper()
+
+	v := semvers.V1_0_0
+	ds := datastore.NewMemoryDataStore()
+	for _, entry := range []struct {
+		addr string
+		ct   datastore.ContractType
+	}{
+		{solutils.GetProgramID(solutils.ProgAccessController), datastore.ContractType(mcmscontracts.AccessControllerProgram)},
+		{solutils.GetProgramID(solutils.ProgMCM), datastore.ContractType(mcmscontracts.ManyChainMultisigProgram)},
+		{solutils.GetProgramID(solutils.ProgTimelock), datastore.ContractType(mcmscontracts.RBACTimelockProgram)},
+	} {
+		require.NoError(t, ds.Addresses().Add(datastore.AddressRef{
+			ChainSelector: selector,
+			Address:       entry.addr,
+			Type:          entry.ct,
+			Version:       &v,
+		}))
+	}
+
+	return ds.Seal()
+}

legacy/pkg/family/solana/testutils/preload.go

@@ -86,3 +86,13 @@ func PreloadMCMS(t *testing.T, selector uint64) (string, map[string]string, *cld
 
 	return programsPath, programIDs, ab
 }
+
+// LoadMCMSPrograms downloads MCMS Solana program artifacts once per test process
+// and returns the shared cache directory plus program IDs.
+func LoadMCMSPrograms(t *testing.T) (string, map[string]string) {
+	t.Helper()
+
+	acquireSolanaTestIsolation(t)
+
+	return sharedMCMSPrograms(t)
+}

mcms/changesets/set-config/changeset_test.go

@@ -14,6 +14,7 @@ import (
 
 	chain_selectors "github.com/smartcontractkit/chain-selectors"
 	cldf_evm "github.com/smartcontractkit/chainlink-deployments-framework/chain/evm"
+	"github.com/smartcontractkit/chainlink-deployments-framework/datastore"
 	cldf "github.com/smartcontractkit/chainlink-deployments-framework/deployment"
 	mcmscontracts "github.com/smartcontractkit/chainlink-deployments-framework/engine/cld/contracts/mcms"
 	cldfproposalutils "github.com/smartcontractkit/chainlink-deployments-framework/engine/cld/mcms/proposalutils"
@@ -25,15 +26,14 @@ import (
 
 	"github.com/smartcontractkit/cld-changesets/datastore/refkey"
 	"github.com/smartcontractkit/cld-changesets/internal/semvers"
-
-	// TODO: remove legacymcms import once remaining MCMS changesets are migrated out of legacy/mcms/changesets.
-	legacymcms "github.com/smartcontractkit/cld-changesets/legacy/mcms/changesets"
-	evmstate "github.com/smartcontractkit/cld-changesets/legacy/pkg/family/evm"
 	solstate "github.com/smartcontractkit/cld-changesets/legacy/pkg/family/solana"
 	solchangesets "github.com/smartcontractkit/cld-changesets/legacy/pkg/family/solana/changesets"
 	soltestutils "github.com/smartcontractkit/cld-changesets/legacy/pkg/family/solana/testutils"
+	"github.com/smartcontractkit/cld-changesets/mcms/changesets/deploy"
 	setconfig "github.com/smartcontractkit/cld-changesets/mcms/changesets/set-config"
 	_ "github.com/smartcontractkit/cld-changesets/mcms/changesets/set-config/all"
+	_ "github.com/smartcontractkit/cld-changesets/mcms/evm/deploy"
+	evmreaders "github.com/smartcontractkit/cld-changesets/mcms/evm/readers"
 )
 
 //nolint:paralleltest // global mcm.SetProgramID state and shared Solana CTF container setup
@@ -241,14 +241,14 @@ func TestChangeset_EVM(t *testing.T) {
 		},
 	} {
 		t.Run(tt.name, func(t *testing.T) {
-			mcmsState, _ := evmMCMSChainState(t, rt, tt.selector)
+			mcmsRefs, _ := loadEVMMCMSRefs(t, rt, tt.selector)
 			originalCfg := cldftesthelpers.SingleGroupMCMS(t)
 
 			var targets []setconfig.ContractSetConfig
 			var mcmsInput *cldf.MCMSTimelockProposalInput
 			if tt.useMCMS {
 				cfgCanceller := cldftesthelpers.SingleGroupMCMS(t)
-				cfgCanceller.Signers = append(cfgCanceller.Signers, mcmsState.BypasserMcm.Address())
+				cfgCanceller.Signers = append(cfgCanceller.Signers, mcmsRefs.Bypasser)
 				cfgCanceller.Quorum = 2
 				targets = []setconfig.ContractSetConfig{
 					{
@@ -258,15 +258,15 @@ func TestChangeset_EVM(t *testing.T) {
 				}
 				mcmsInput = newMCMSInput(mcmstypes.TimelockActionBypass, "Set config proposal", "")
 			} else {
-				timelockAddress := mcmsState.Timelock.Address()
+				timelockAddress := mcmsRefs.Timelock
 
 				cfgProposer := cldftesthelpers.SingleGroupMCMS(t)
 				cfgProposer.Signers = append(cfgProposer.Signers, timelockAddress)
 				cfgProposer.Quorum = 2
 				cfgCanceller := cldftesthelpers.SingleGroupMCMS(t)
 				cfgBypasser := cldftesthelpers.SingleGroupMCMS(t)
 				cfgBypasser.Signers = append(cfgBypasser.Signers, timelockAddress)
-				cfgBypasser.Signers = append(cfgBypasser.Signers, mcmsState.ProposerMcm.Address())
+				cfgBypasser.Signers = append(cfgBypasser.Signers, mcmsRefs.Proposer)
 				cfgBypasser.Quorum = 3
 
 				targets = mcmsTargets(tt.selector, cfgProposer, cfgCanceller, cfgBypasser)
@@ -286,17 +286,17 @@ func TestChangeset_EVM(t *testing.T) {
 
 			if tt.useMCMS {
 				cfgCanceller := targets[0].Config
-				newConf, err := inspector.GetConfig(t.Context(), mcmsState.CancellerMcm.Address().Hex())
+				newConf, err := inspector.GetConfig(t.Context(), mcmsRefs.Canceller.Hex())
 				require.NoError(t, err)
 				require.ElementsMatch(t, cfgCanceller.Signers, newConf.Signers)
 				require.Equal(t, cfgCanceller.Quorum, newConf.Quorum)
 
-				proposerConf, err := inspector.GetConfig(t.Context(), mcmsState.ProposerMcm.Address().Hex())
+				proposerConf, err := inspector.GetConfig(t.Context(), mcmsRefs.Proposer.Hex())
 				require.NoError(t, err)
 				require.ElementsMatch(t, originalCfg.Signers, proposerConf.Signers)
 				require.Equal(t, originalCfg.Quorum, proposerConf.Quorum)
 
-				bypasserConf, err := inspector.GetConfig(t.Context(), mcmsState.BypasserMcm.Address().Hex())
+				bypasserConf, err := inspector.GetConfig(t.Context(), mcmsRefs.Bypasser.Hex())
 				require.NoError(t, err)
 				require.ElementsMatch(t, originalCfg.Signers, bypasserConf.Signers)
 				require.Equal(t, originalCfg.Quorum, bypasserConf.Quorum)
@@ -308,17 +308,17 @@ func TestChangeset_EVM(t *testing.T) {
 			cfgCanceller := targets[1].Config
 			cfgBypasser := targets[2].Config
 
-			newConf, err := inspector.GetConfig(t.Context(), mcmsState.ProposerMcm.Address().Hex())
+			newConf, err := inspector.GetConfig(t.Context(), mcmsRefs.Proposer.Hex())
 			require.NoError(t, err)
 			require.ElementsMatch(t, cfgProposer.Signers, newConf.Signers)
 			require.Equal(t, cfgProposer.Quorum, newConf.Quorum)
 
-			newConf, err = inspector.GetConfig(t.Context(), mcmsState.BypasserMcm.Address().Hex())
+			newConf, err = inspector.GetConfig(t.Context(), mcmsRefs.Bypasser.Hex())
 			require.NoError(t, err)
 			require.ElementsMatch(t, cfgBypasser.Signers, newConf.Signers)
 			require.Equal(t, cfgBypasser.Quorum, newConf.Quorum)
 
-			newConf, err = inspector.GetConfig(t.Context(), mcmsState.CancellerMcm.Address().Hex())
+			newConf, err = inspector.GetConfig(t.Context(), mcmsRefs.Canceller.Hex())
 			require.NoError(t, err)
 			require.ElementsMatch(t, cfgCanceller.Signers, newConf.Signers)
 			require.Equal(t, cfgCanceller.Quorum, newConf.Quorum)
@@ -332,10 +332,10 @@ func TestChangeset_EVM_PartialTargets(t *testing.T) {
 	selector := chain_selectors.TEST_90000001.Selector
 
 	rt := newEVMRuntimeWithDeploy(t, selector)
-	mcmsState, chain := evmMCMSChainState(t, rt, selector)
+	mcmsRefs, chain := loadEVMMCMSRefs(t, rt, selector)
 
 	cfgProposer := cldftesthelpers.SingleGroupMCMS(t)
-	cfgProposer.Signers = append(cfgProposer.Signers, mcmsState.Timelock.Address())
+	cfgProposer.Signers = append(cfgProposer.Signers, mcmsRefs.Timelock)
 	cfgProposer.Quorum = 2
 
 	err := rt.Exec(
@@ -354,17 +354,17 @@ func TestChangeset_EVM_PartialTargets(t *testing.T) {
 	inspector := evm.NewInspector(chain.Client)
 	originalCfg := cldftesthelpers.SingleGroupMCMS(t)
 
-	proposerConf, err := inspector.GetConfig(t.Context(), mcmsState.ProposerMcm.Address().Hex())
+	proposerConf, err := inspector.GetConfig(t.Context(), mcmsRefs.Proposer.Hex())
 	require.NoError(t, err)
 	require.ElementsMatch(t, cfgProposer.Signers, proposerConf.Signers)
 	require.Equal(t, cfgProposer.Quorum, proposerConf.Quorum)
 
-	cancellerConf, err := inspector.GetConfig(t.Context(), mcmsState.CancellerMcm.Address().Hex())
+	cancellerConf, err := inspector.GetConfig(t.Context(), mcmsRefs.Canceller.Hex())
 	require.NoError(t, err)
 	require.ElementsMatch(t, originalCfg.Signers, cancellerConf.Signers)
 	require.Equal(t, originalCfg.Quorum, cancellerConf.Quorum)
 
-	bypasserConf, err := inspector.GetConfig(t.Context(), mcmsState.BypasserMcm.Address().Hex())
+	bypasserConf, err := inspector.GetConfig(t.Context(), mcmsRefs.Bypasser.Hex())
 	require.NoError(t, err)
 	require.ElementsMatch(t, originalCfg.Signers, bypasserConf.Signers)
 	require.Equal(t, originalCfg.Quorum, bypasserConf.Quorum)
@@ -386,21 +386,26 @@ func TestChangeset_EVM_Qualifier(t *testing.T) {
 	rmnmcmsConfig.Qualifier = &rmnmcmsQualifier
 
 	err := rt.Exec(
-		runtime.ChangesetTask(cldf.CreateLegacyChangeSet(legacymcms.DeployMCMSWithTimelockV2), map[uint64]cldfproposalutils.MCMSWithTimelockConfig{
-			selector: cllccipConfig,
+		runtime.ChangesetTask(deploy.Changeset{}, deploy.Input{
+			ConfigByChain: map[uint64]cldfproposalutils.MCMSWithTimelockConfig{
+				selector: cllccipConfig,
+			},
 		}),
-		runtime.ChangesetTask(cldf.CreateLegacyChangeSet(legacymcms.DeployMCMSWithTimelockV2), map[uint64]cldfproposalutils.MCMSWithTimelockConfig{
-			selector: rmnmcmsConfig,
+		runtime.ChangesetTask(deploy.Changeset{}, deploy.Input{
+			ConfigByChain: map[uint64]cldfproposalutils.MCMSWithTimelockConfig{
+				selector: rmnmcmsConfig,
+			},
 		}),
 	)
 	require.NoError(t, err)
 
-	cllccipState, err := evmstate.MaybeLoadMCMSWithTimelockStateWithQualifier(rt.Environment(), []uint64{selector}, cllccipQualifier)
+	cllccipTimelock, err := evmreaders.Reader{}.GetTimelockRef(rt.Environment(), selector, cldf.MCMSTimelockProposalInput{
+		Qualifier: cllccipQualifier,
+	})
 	require.NoError(t, err)
-	require.NotNil(t, cllccipState[selector])
 
 	cfgProposer := cldftesthelpers.SingleGroupMCMS(t)
-	cfgProposer.Signers = append(cfgProposer.Signers, cllccipState[selector].Timelock.Address())
+	cfgProposer.Signers = append(cfgProposer.Signers, common.HexToAddress(cllccipTimelock.Address))
 	cfgProposer.Quorum = 2
 
 	for _, tt := range []struct {
@@ -479,9 +484,8 @@ func TestChangeset_Solana(t *testing.T) {
 	rt := newSolanaRuntimeWithDeploy(t, selector)
 	chain := rt.Environment().BlockChains.SolanaChains()[selector]
 
-	addrs, err := rt.State().AddressBook.AddressesForChain(selector)
-	require.NoError(t, err)
-	mcmsState, err := solstate.MaybeLoadMCMSWithTimelockChainState(chain, addrs)
+	refs := rt.State().DataStore.Addresses().Filter(datastore.AddressRefByChainSelector(selector))
+	mcmsState, err := solstate.MaybeLoadMCMSWithTimelockChainStateV2(refs)
 	require.NoError(t, err)
 	soltestutils.FundSignerPDAs(t, chain, mcmsState)
 

mcms/changesets/set-config/helpers_test.go

@@ -25,13 +25,18 @@ import (
 
 	"github.com/smartcontractkit/cld-changesets/datastore/refkey"
 	"github.com/smartcontractkit/cld-changesets/internal/semvers"
+	"github.com/smartcontractkit/cld-changesets/internal/testutil/solanatest"
 
-	// TODO: remove legacymcms import once remaining MCMS changesets are migrated out of legacy/mcms/changesets.
-	legacymcms "github.com/smartcontractkit/cld-changesets/legacy/mcms/changesets"
-	evmstate "github.com/smartcontractkit/cld-changesets/legacy/pkg/family/evm"
 	soltestutils "github.com/smartcontractkit/cld-changesets/legacy/pkg/family/solana/testutils"
+	"github.com/smartcontractkit/cld-changesets/mcms/changesets/deploy"
 	setconfig "github.com/smartcontractkit/cld-changesets/mcms/changesets/set-config"
 	_ "github.com/smartcontractkit/cld-changesets/mcms/changesets/set-config/all"
+	transfertotimelock "github.com/smartcontractkit/cld-changesets/mcms/changesets/transfer-to-timelock"
+	_ "github.com/smartcontractkit/cld-changesets/mcms/evm/deploy"
+	_ "github.com/smartcontractkit/cld-changesets/mcms/evm/readers"
+	evmreaders "github.com/smartcontractkit/cld-changesets/mcms/evm/readers"
+	_ "github.com/smartcontractkit/cld-changesets/mcms/evm/transfer-to-timelock"
+	_ "github.com/smartcontractkit/cld-changesets/mcms/solana/deploy"
 )
 
 func contractRef(chainSelector uint64, contractType cldf.ContractType, qualifier string) refkey.RefKey {
@@ -92,10 +97,9 @@ func deployEVMMCMSWithTimelock(t *testing.T, rt *runtime.Runtime, selectors ...u
 		configByChain[selector] = cfg
 	}
 
-	err := rt.Exec(
-		// TODO: replace with new deploy changeset when available
-		runtime.ChangesetTask(cldf.CreateLegacyChangeSet(legacymcms.DeployMCMSWithTimelockV2), configByChain),
-	)
+	err := rt.Exec(runtime.ChangesetTask(deploy.Changeset{}, deploy.Input{
+		ConfigByChain: configByChain,
+	}))
 	require.NoError(t, err)
 }
 
@@ -111,17 +115,25 @@ func newEVMRuntimeWithDeploy(t *testing.T, selectors ...uint64) *runtime.Runtime
 func transferEVMMCMSToTimelock(t *testing.T, rt *runtime.Runtime, selector uint64) {
 	t.Helper()
 
-	mcmsState, _ := evmMCMSChainState(t, rt, selector)
+	mcmsRefs, _ := loadEVMMCMSRefs(t, rt, selector)
 
 	err := rt.Exec(
-		runtime.ChangesetTask(cldf.CreateLegacyChangeSet(legacymcms.TransferToMCMSWithTimelockV2), legacymcms.TransferToMCMSWithTimelockConfig{
-			ContractsByChain: map[uint64][]common.Address{
-				selector: {
-					mcmsState.ProposerMcm.Address(),
-					mcmsState.BypasserMcm.Address(),
-					mcmsState.CancellerMcm.Address(),
+		runtime.ChangesetTask(transfertotimelock.Changeset{}, transfertotimelock.Input{
+			Cfg: transfertotimelock.Config{
+				ContractsByChain: map[uint64][]common.Address{
+					selector: {
+						mcmsRefs.Proposer,
+						mcmsRefs.Bypasser,
+						mcmsRefs.Canceller,
+					},
 				},
 			},
+			MCMS: &cldf.MCMSTimelockProposalInput{
+				TimelockAction: mcmstypes.TimelockActionBypass,
+				ValidUntil:     uint32(time.Now().Add(2 * time.Hour).UTC().Unix()), //nolint:gosec // test timestamp
+				TimelockDelay:  mcmstypes.NewDuration(0),
+				Description:    "transfer MCM to timelock",
+			},
 		}),
 		runtime.SignAndExecuteProposalsTask([]*ecdsa.PrivateKey{cldftesthelpers.TestXXXMCMSSigner}),
 	)
@@ -137,17 +149,41 @@ func newEVMRuntimeWithDeployAndTransfer(t *testing.T, selector uint64) *runtime.
 	return rt
 }
 
-func evmMCMSChainState(t *testing.T, rt *runtime.Runtime, selector uint64) (*evmstate.MCMSWithTimelockState, cldf_evm.Chain) {
+type evmMCMSRefs struct {
+	Timelock  common.Address
+	Proposer  common.Address
+	Canceller common.Address
+	Bypasser  common.Address
+}
+
+func loadEVMMCMSRefs(t *testing.T, rt *runtime.Runtime, selector uint64) (evmMCMSRefs, cldf_evm.Chain) {
 	t.Helper()
 
-	chain := rt.Environment().BlockChains.EVMChains()[selector]
-	addrs, err := rt.State().AddressBook.AddressesForChain(selector)
-	require.NoError(t, err)
+	env := rt.Environment()
+	chain := env.BlockChains.EVMChains()[selector]
 
-	mcmsState, err := evmstate.MaybeLoadMCMSWithTimelockChainState(chain, addrs)
+	reader := evmreaders.Reader{}
+	timelock, err := reader.GetTimelockRef(env, selector, cldf.MCMSTimelockProposalInput{})
+	require.NoError(t, err)
+	proposer, err := reader.GetMCMSRef(env, selector, cldf.MCMSTimelockProposalInput{
+		TimelockAction: mcmstypes.TimelockActionSchedule,
+	})
+	require.NoError(t, err)
+	canceller, err := reader.GetMCMSRef(env, selector, cldf.MCMSTimelockProposalInput{
+		TimelockAction: mcmstypes.TimelockActionCancel,
+	})
+	require.NoError(t, err)
+	bypasser, err := reader.GetMCMSRef(env, selector, cldf.MCMSTimelockProposalInput{
+		TimelockAction: mcmstypes.TimelockActionBypass,
+	})
 	require.NoError(t, err)
 
-	return mcmsState, chain
+	return evmMCMSRefs{
+		Timelock:  common.HexToAddress(timelock.Address),
+		Proposer:  common.HexToAddress(proposer.Address),
+		Canceller: common.HexToAddress(canceller.Address),
+		Bypasser:  common.HexToAddress(bypasser.Address),
+	}, chain
 }
 
 // newSolanaVerifyPreconditionsEnv builds a mock Solana environment for VerifyPreconditions
@@ -189,18 +225,20 @@ func newSolanaVerifyPreconditionsEnv(t *testing.T, selector uint64) cldf.Environ
 func newSolanaRuntimeWithDeploy(t *testing.T, selector uint64) *runtime.Runtime {
 	t.Helper()
 
-	programsPath, programIDs, ab := soltestutils.PreloadMCMS(t, selector)
+	programsPath, programIDs := soltestutils.LoadMCMSPrograms(t)
 	rt, err := runtime.New(t.Context(), runtime.WithEnvOpts(
 		environment.WithSolanaContainer(t, []uint64{selector}, programsPath, programIDs),
-		environment.WithAddressBook(ab),
+		environment.WithDatastore(solanatest.PreloadDatastoreWithMCMSPrograms(t, selector)),
 		environment.WithLogger(logger.Test(t)),
 	))
 	require.NoError(t, err)
 	require.Contains(t, rt.Environment().BlockChains.SolanaChains(), selector)
 
 	err = rt.Exec(
-		runtime.ChangesetTask(cldf.CreateLegacyChangeSet(legacymcms.DeployMCMSWithTimelockV2), map[uint64]cldfproposalutils.MCMSWithTimelockConfig{
-			selector: cldftesthelpers.SingleGroupTimelockConfig(t),
+		runtime.ChangesetTask(deploy.Changeset{}, deploy.Input{
+			ConfigByChain: map[uint64]cldfproposalutils.MCMSWithTimelockConfig{
+				selector: cldftesthelpers.SingleGroupTimelockConfig(t),
+			},
 		}),
 	)
 	require.NoError(t, err)