fix: linting and unit tests

Author: ecPablo

go.mod

@@ -14,6 +14,7 @@ require (
 	github.com/google/go-cmp v0.7.0
 	github.com/mr-tron/base58 v1.2.0
 	github.com/samber/lo v1.53.0
+	github.com/segmentio/ksuid v1.0.4
 	github.com/smartcontractkit/ccip-owner-contracts v0.1.0
 	github.com/smartcontractkit/chain-selectors v1.0.102
 	github.com/smartcontractkit/chainlink-ccip/chains/solana v0.0.0-20260415165642-49f23e4d76cc
@@ -230,7 +231,6 @@ require (
 	github.com/sagikazarmark/locafero v0.11.0 // indirect
 	github.com/santhosh-tekuri/jsonschema/v5 v5.3.1 // indirect
 	github.com/scylladb/go-reflectx v1.0.1 // indirect
-	github.com/segmentio/ksuid v1.0.4 // indirect
 	github.com/shirou/gopsutil v3.21.11+incompatible // indirect
 	github.com/shirou/gopsutil/v4 v4.26.3 // indirect
 	github.com/shopspring/decimal v1.4.0 // indirect

mcms/changesets/set-config/changeset_test.go

@@ -36,9 +36,8 @@ import (
 	setconfigtypes "github.com/smartcontractkit/cld-changesets/mcms/changesets/set-config/types"
 )
 
+//nolint:paralleltest // global mcm.SetProgramID state and shared Solana CTF container setup
 func TestChangeset_VerifyPreconditions(t *testing.T) {
-	t.Parallel()
-
 	evmSelector := chain_selectors.TEST_90000001.Selector
 	solSelector := chain_selectors.TEST_22222222222222222222222222222222222222222222.Selector
 
@@ -51,6 +50,7 @@ func TestChangeset_VerifyPreconditions(t *testing.T) {
 		environment.WithLogger(logger.Test(t)),
 	))
 	require.NoError(t, err)
+	require.Contains(t, rt.Environment().BlockChains.SolanaChains(), solSelector)
 
 	config := cldftesthelpers.SingleGroupTimelockConfig(t)
 	err = rt.Exec(
@@ -416,7 +416,7 @@ func TestChangeset_EVM_Qualifier(t *testing.T) {
 			name:      "missing qualifier",
 			qualifier: "",
 			wantErr: fmt.Sprintf(
-				"validate timelock ref for chain %s: multiple address refs matched query: expected exactly 1 ref matching query {ChainSelector: %s, Type: %s}, found 2",
+				"family evm: validate timelock ref for chain %s: multiple address refs matched query: expected exactly 1 ref matching query {ChainSelector: %s, Type: %s}, found 2",
 				selectorStr,
 				selectorStr,
 				mcmscontracts.RBACTimelock,
@@ -426,7 +426,7 @@ func TestChangeset_EVM_Qualifier(t *testing.T) {
 			name:      "unknown qualifier",
 			qualifier: "does-not-exist",
 			wantErr: fmt.Sprintf(
-				"validate timelock ref for chain %s: no address ref matched query: expected exactly 1 ref matching query {ChainSelector: %s, Type: %s, Qualifier: does-not-exist}, found 0",
+				"family evm: validate timelock ref for chain %s: no address ref matched query: expected exactly 1 ref matching query {ChainSelector: %s, Type: %s, Qualifier: does-not-exist}, found 0",
 				selectorStr,
 				selectorStr,
 				mcmscontracts.RBACTimelock,
@@ -476,9 +476,8 @@ func TestChangeset_EVM_BuildsProposalWithoutExecute(t *testing.T) {
 	require.NotEmpty(t, output.Reports)
 }
 
+//nolint:paralleltest // global mcm.SetProgramID state and shared Solana CTF container setup
 func TestChangeset_Solana(t *testing.T) {
-	t.Parallel()
-
 	selector := chain_selectors.TEST_22222222222222222222222222222222222222222222.Selector
 	programsPath, programIDs, ab := soltestutils.PreloadMCMS(t, selector)
 
@@ -488,6 +487,7 @@ func TestChangeset_Solana(t *testing.T) {
 		environment.WithLogger(logger.Test(t)),
 	))
 	require.NoError(t, err)
+	require.Contains(t, rt.Environment().BlockChains.SolanaChains(), selector)
 
 	chain := rt.Environment().BlockChains.SolanaChains()[selector]
 

mcms/solana/set-config/operation_test.go

@@ -17,6 +17,7 @@ import (
 	mcmstypes "github.com/smartcontractkit/mcms/types"
 )
 
+//nolint:paralleltest // global mcm.SetProgramID state
 func TestOpSolanaSetConfigMCM(t *testing.T) {
 	tests := []struct {
 		name   string

mcms/solana/set-config/register.go

@@ -28,7 +28,7 @@ func Registration() setconfigregistry.Registration {
 func verifySolanaChains(env cldf.Environment, chains []setconfigtypes.ChainInput) error {
 	for _, in := range chains {
 		if _, ok := env.BlockChains.SolanaChains()[in.ChainSelector]; !ok {
-			return fmt.Errorf("Solana chain %d not found in environment", in.ChainSelector)
+			return fmt.Errorf("solana chain %d not found in environment", in.ChainSelector)
 		}
 		if err := validateMCMSIfPresent(env, in); err != nil {
 			return err

mcms/solana/set-config/sequence.go

@@ -73,7 +73,7 @@ func runSolanaSetConfig(
 ) (sequenceutils.OnChainOutput, error) {
 	chain, ok := deps.BlockChains.SolanaChains()[in.ChainSelector]
 	if !ok {
-		return sequenceutils.OnChainOutput{}, fmt.Errorf("Solana chain %d not found in environment", in.ChainSelector)
+		return sequenceutils.OnChainOutput{}, fmt.Errorf("solana chain %d not found in environment", in.ChainSelector)
 	}
 
 	env := setconfigtypes.EnvFromDeps(deps)

mcms/solana/set-config/sequence_test.go

@@ -32,6 +32,7 @@ import (
 	solreaders "github.com/smartcontractkit/cld-changesets/mcms/solana/readers"
 )
 
+//nolint:paralleltest // global mcm.SetProgramID state
 func TestSeqSolanaSetConfig(t *testing.T) {
 	tests := []struct {
 		name   string