test(mcms): optimise container startups (#112)

The original tests which include spinning up solana containers take up a
good chunk of time

```
github.com/smartcontractkit/cld-changesets/legacy/mcms/changesets	112.753s	coverage: 67.1% of statements
github.com/smartcontractkit/cld-changesets/mcms/changesets/set-config	133.902s	coverage: 91.2% of statements
github.com/smartcontractkit/cld-changesets/mcms/solana/changesets/fund-mcm-pdas	60.253s	coverage: 89.7% of statements
```

I have since optimised it by doing:
- reduce container startups by having multple tests share the same
container if there are no conflicts
- reduce duplicate tests in the sequence or operation tests when the
same flow has been covered by the integration test at changeset_test.go

After optimisation
```
❯ go test ./mcms/... -count=1         
?       github.com/smartcontractkit/cld-changesets/mcms/changesets      [no test files]
?       github.com/smartcontractkit/cld-changesets/mcms/changesets/deploy       [no test files]
ok      github.com/smartcontractkit/cld-changesets/mcms/changesets/deploy-custom-topology       1.897s
ok      github.com/smartcontractkit/cld-changesets/mcms/changesets/firedrill    1.154s
?       github.com/smartcontractkit/cld-changesets/mcms/changesets/firedrill/all        [no test files]
ok      github.com/smartcontractkit/cld-changesets/mcms/changesets/grant-role   2.702s
?       github.com/smartcontractkit/cld-changesets/mcms/changesets/grant-role/all       [no test files]
ok      github.com/smartcontractkit/cld-changesets/mcms/changesets/set-config   2.160s
?       github.com/smartcontractkit/cld-changesets/mcms/changesets/set-config/all       [no test files]
ok      github.com/smartcontractkit/cld-changesets/mcms/changesets/transfer-to-timelock 2.395s
?       github.com/smartcontractkit/cld-changesets/mcms/changesets/transfer-to-timelock/all     [no test files]
ok      github.com/smartcontractkit/cld-changesets/mcms/evm/deploy      3.165s
?       github.com/smartcontractkit/cld-changesets/mcms/evm/deploy/v1_0_0/operations/call_proxy [no test files]
?       github.com/smartcontractkit/cld-changesets/mcms/evm/deploy/v1_0_0/operations/many_chain_multi_sig       [no test files]
?       github.com/smartcontractkit/cld-changesets/mcms/evm/deploy/v1_0_0/operations/rbac_timelock      [no test files]
ok      github.com/smartcontractkit/cld-changesets/mcms/evm/deploy-custom-topology      1.281s
ok      github.com/smartcontractkit/cld-changesets/mcms/evm/firedrill   2.177s
ok      github.com/smartcontractkit/cld-changesets/mcms/evm/grant-role  6.359s
ok      github.com/smartcontractkit/cld-changesets/mcms/evm/internal/gasboost   3.336s
ok      github.com/smartcontractkit/cld-changesets/mcms/evm/readers     10.430s
ok      github.com/smartcontractkit/cld-changesets/mcms/evm/set-config  7.381s
ok      github.com/smartcontractkit/cld-changesets/mcms/evm/transfer-to-timelock        4.490s
?       github.com/smartcontractkit/cld-changesets/mcms/evm/transfer-to-timelock/v1_0_0/operations/burn_mint_erc677     [no test files]
ok      github.com/smartcontractkit/cld-changesets/mcms/operations      10.392s
?       github.com/smartcontractkit/cld-changesets/mcms/solana/changesets       [no test files]
ok      github.com/smartcontractkit/cld-changesets/mcms/solana/changesets/fund-mcm-pdas 37.022s
ok      github.com/smartcontractkit/cld-changesets/mcms/solana/deploy   56.093s
ok      github.com/smartcontractkit/cld-changesets/mcms/solana/firedrill        49.339s
ok      github.com/smartcontractkit/cld-changesets/mcms/solana/readers  11.145s
ok      github.com/smartcontractkit/cld-changesets/mcms/solana/set-config       55.496s
```

Author: graham-chainlink

internal/testutil/solanatest/datastore.go

@@ -0,0 +1,42 @@
+// Package solanatest provides test utilities for Solana MCMS integration tests.
+package solanatest
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/require"
+
+	"github.com/smartcontractkit/chainlink-deployments-framework/datastore"
+	mcmscontracts "github.com/smartcontractkit/chainlink-deployments-framework/engine/cld/contracts/mcms"
+
+	"github.com/smartcontractkit/cld-changesets/internal/semvers"
+	"github.com/smartcontractkit/cld-changesets/legacy/pkg/family/solana/solutils"
+)
+
+// NewDataStoreWithMCMSPrograms seeds a datastore with canonical MCMS program IDs.
+// The test validator preloads the same programs via WithSolanaContainer; program
+// deploy is skipped because artifacts lack -keypair.json files required by
+// solana program deploy for fixed program IDs.
+func NewDataStoreWithMCMSPrograms(t *testing.T, selector uint64) datastore.DataStore {
+	t.Helper()
+
+	v := semvers.V1_0_0
+	ds := datastore.NewMemoryDataStore()
+	for _, entry := range []struct {
+		addr string
+		ct   datastore.ContractType
+	}{
+		{solutils.GetProgramID(solutils.ProgAccessController), datastore.ContractType(mcmscontracts.AccessControllerProgram)},
+		{solutils.GetProgramID(solutils.ProgMCM), datastore.ContractType(mcmscontracts.ManyChainMultisigProgram)},
+		{solutils.GetProgramID(solutils.ProgTimelock), datastore.ContractType(mcmscontracts.RBACTimelockProgram)},
+	} {
+		require.NoError(t, ds.Addresses().Add(datastore.AddressRef{
+			ChainSelector: selector,
+			Address:       entry.addr,
+			Type:          entry.ct,
+			Version:       &v,
+		}))
+	}
+
+	return ds.Seal()
+}

internal/testutil/solanatest/proposal.go

@@ -0,0 +1,77 @@
+package solanatest
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/require"
+
+	mcmscontracts "github.com/smartcontractkit/chainlink-deployments-framework/engine/cld/contracts/mcms"
+	mcmslib "github.com/smartcontractkit/mcms"
+	mcmssolana "github.com/smartcontractkit/mcms/sdk/solana"
+	mcmstypes "github.com/smartcontractkit/mcms/types"
+
+	solstate "github.com/smartcontractkit/cld-changesets/legacy/pkg/family/solana"
+)
+
+// AssertMCMSSetConfigProposal verifies structure of a Solana set-config MCMS timelock proposal
+// without executing it on-chain. Batch ops may appear as one merged operation per chain (new
+// changeset output builder) or one operation per MCM role (legacy proposeutils path).
+func AssertMCMSSetConfigProposal(
+	t *testing.T,
+	selector uint64,
+	mcmsState *solstate.MCMSWithTimelockState,
+	proposal mcmslib.TimelockProposal,
+	wantAction mcmstypes.TimelockAction,
+	wantDelay mcmstypes.Duration,
+	wantDescription string,
+) {
+	t.Helper()
+
+	require.Equal(t, wantAction, proposal.Action)
+	require.Equal(t, wantDelay, proposal.Delay)
+	require.Equal(t, wantDescription, proposal.Description)
+
+	timelockAddr := mcmssolana.ContractAddress(mcmsState.TimelockProgram, mcmssolana.PDASeed(mcmsState.TimelockSeed))
+	require.Equal(t, timelockAddr, proposal.TimelockAddresses[mcmstypes.ChainSelector(selector)])
+
+	wantContractTypes := []string{
+		string(mcmscontracts.ProposerManyChainMultisig),
+		string(mcmscontracts.CancellerManyChainMultisig),
+		string(mcmscontracts.BypasserManyChainMultisig),
+	}
+	require.NotEmpty(t, proposal.Operations)
+
+	mcmProgram := mcmsState.McmProgram.String()
+	gotContractTypes := make([]string, 0, len(wantContractTypes))
+
+	for _, op := range proposal.Operations {
+		require.Equal(t, mcmstypes.ChainSelector(selector), op.ChainSelector)
+		require.NotEmpty(t, op.Transactions)
+
+		for _, tx := range op.Transactions {
+			require.Equal(t, mcmProgram, tx.To)
+			require.NotEmpty(t, tx.Data)
+			require.NotEmpty(t, tx.ContractType)
+			gotContractTypes = append(gotContractTypes, tx.ContractType)
+		}
+	}
+
+	require.ElementsMatch(t, wantContractTypes, uniqueStrings(gotContractTypes))
+	for _, contractType := range wantContractTypes {
+		require.Contains(t, gotContractTypes, contractType)
+	}
+}
+
+func uniqueStrings(values []string) []string {
+	seen := make(map[string]struct{}, len(values))
+	unique := make([]string, 0, len(values))
+	for _, v := range values {
+		if _, ok := seen[v]; ok {
+			continue
+		}
+		seen[v] = struct{}{}
+		unique = append(unique, v)
+	}
+
+	return unique
+}

legacy/mcms/changesets/set_config_mcms_test.go

@@ -3,7 +3,6 @@ package changesets
 import (
 	"crypto/ecdsa"
 	"testing"
-	"time"
 
 	"github.com/ethereum/go-ethereum/common"
 	"github.com/ethereum/go-ethereum/crypto"
@@ -22,9 +21,9 @@ import (
 	"github.com/smartcontractkit/mcms/sdk/solana"
 	mcmstypes "github.com/smartcontractkit/mcms/types"
 
+	"github.com/smartcontractkit/cld-changesets/internal/testutil/solanatest"
 	evmstate "github.com/smartcontractkit/cld-changesets/legacy/pkg/family/evm"
 	solstate "github.com/smartcontractkit/cld-changesets/legacy/pkg/family/solana"
-	"github.com/smartcontractkit/cld-changesets/legacy/pkg/family/solana/changesets"
 	soltestutils "github.com/smartcontractkit/cld-changesets/legacy/pkg/family/solana/testutils"
 	linkchangesets "github.com/smartcontractkit/cld-changesets/tokens/link/changesets"
 )
@@ -202,8 +201,7 @@ func TestSetConfigMCMSV2Solana(t *testing.T) {
 	inspector := solana.NewInspector(chain.Client)
 
 	// Create some signers to set into the config
-	signer1Key, signer1Addr := createSolSigner(t)
-	_, signer2Addr := createSolSigner(t)
+	_, signer1Addr := createSolSigner(t)
 
 	newCfgProposer := cldftesthelpers.SingleGroupMCMS(t)
 	newCfgProposer.Signers = append(newCfgProposer.Signers, signer1Addr)
@@ -233,44 +231,30 @@ func TestSetConfigMCMSV2Solana(t *testing.T) {
 		assertSolConfigEquals(t, inspector, mcmsState.McmProgram, mcmsState.CancellerMcmSeed, newCfgCanceller)
 	})
 
-	t.Run("MCMS enabled", func(t *testing.T) { //nolint:paralleltest
-		// Now we transfer the MCMS contracts to the timelock for testing setConfig on MCMS owned contracts
-		err = rt.Exec(
-			runtime.ChangesetTask(changesets.TransferMCMSToTimelockSolana{}, changesets.TransferMCMSToTimelockSolanaConfig{
-				Chains:  []uint64{selector},
-				MCMSCfg: cldfproposalutils.TimelockConfig{MinDelay: time.Second * 1},
-			}),
-			// We must sign with an additional signer since we changed the config quorum previously.
-			runtime.SignAndExecuteProposalsTask([]*ecdsa.PrivateKey{cldftesthelpers.TestXXXMCMSSigner, signer1Key}),
-		)
-		require.NoError(t, err)
-
-		// Update the configs with yet another additional signer
-		newCfgProposer.Signers = append(newCfgProposer.Signers, signer2Addr)
-		newCfgProposer.Quorum = 3
-		newCfgBypasser.Signers = append(newCfgBypasser.Signers, signer2Addr)
-		newCfgBypasser.Quorum = 3
-
-		err = rt.Exec(
-			runtime.ChangesetTask(cldf.CreateLegacyChangeSet(SetConfigMCMSV2), MCMSConfigV2{
-				ProposalConfig: &cldfproposalutils.TimelockConfig{
-					MinDelay: time.Second * 1,
-				},
-				ConfigsPerChain: map[uint64]ConfigPerRoleV2{
-					selector: {
-						Proposer:  &newCfgProposer,
-						Canceller: &newCfgCanceller,
-						Bypasser:  &newCfgBypasser,
-					},
+	t.Run("builds MCMS proposal without execute", func(t *testing.T) { //nolint:paralleltest
+		cfg := cldftesthelpers.SingleGroupMCMS(t)
+		taskID, err := runtime.ExecChangeset(rt, cldf.CreateLegacyChangeSet(SetConfigMCMSV2), MCMSConfigV2{
+			ProposalConfig: &cldfproposalutils.TimelockConfig{
+				MinDelay:   0,
+				MCMSAction: mcmstypes.TimelockActionBypass,
+			},
+			ConfigsPerChain: map[uint64]ConfigPerRoleV2{
+				selector: {
+					Proposer:  &cfg,
+					Canceller: &cfg,
+					Bypasser:  &cfg,
 				},
-			}),
-			runtime.SignAndExecuteProposalsTask([]*ecdsa.PrivateKey{cldftesthelpers.TestXXXMCMSSigner, signer1Key}),
-		)
+			},
+		})
 		require.NoError(t, err)
 
-		assertSolConfigEquals(t, inspector, mcmsState.McmProgram, mcmsState.ProposerMcmSeed, newCfgProposer)
-		assertSolConfigEquals(t, inspector, mcmsState.McmProgram, mcmsState.BypasserMcmSeed, newCfgBypasser)
-		assertSolConfigEquals(t, inspector, mcmsState.McmProgram, mcmsState.CancellerMcmSeed, newCfgCanceller)
+		output, ok := rt.State().Outputs[taskID]
+		require.True(t, ok)
+		require.Len(t, output.MCMSTimelockProposals, 1)
+		solanatest.AssertMCMSSetConfigProposal(
+			t, selector, mcmsState, output.MCMSTimelockProposals[0],
+			mcmstypes.TimelockActionBypass, mcmstypes.NewDuration(0), "Set config proposal",
+		)
 	})
 }