Skip to content

feat: deploy custom topology mcms [CLD-2766]#100

Merged
ecPablo merged 34 commits into
mainfrom
ecpablo/deploy-topology-mcms
Jun 26, 2026
Merged

feat: deploy custom topology mcms [CLD-2766]#100
ecPablo merged 34 commits into
mainfrom
ecpablo/deploy-topology-mcms

Conversation

@ecPablo

@ecPablo ecPablo commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

To be merged after: #99
Implements the deploy custom topology changeset and sequences for EVM which allows users to deploy custom mcms / timelock structures without custom coding topologies.

AI Summary

This pull request refactors the EVM operations code in the MCMS legacy changesets by consolidating and updating imports to use a newer, centralized evm/operations package. The changes primarily involve replacing references to the old oputil and legacy operation types with the new evmops types and functions, improving maintainability and consistency across the codebase. No functional logic is altered; this is a structural cleanup.

Refactoring and Codebase Cleanup:

  • Replaced all imports of oputil and legacy operation types in multiple files (such as deploy_mcms_with_timelock.go, grant_timelock.go, and various operation and sequence files) with the new evmops package from mcms/evm/operations for EVM operation utilities and types. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]

  • Updated all usages of EVM operation constructors and types (e.g., NewEVMDeployOperation, NewEVMCallOperation, EVMDeployInput, RetryDeploymentWithGasBoost, EVMCallOutput, etc.) to use the new evmops equivalents, ensuring type compatibility and consistency. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16]

  • Adjusted function signatures and return types throughout the EVM operation and sequence logic to use the new types from evmops, removing all direct dependencies on the deprecated oputil package. [1] [2] [3] [4] [5] [6]

This update is a non-functional, structural refactor that will make future maintenance and enhancements easier by consolidating EVM operation logic in a single, modern package.

@github-actions

github-actions Bot commented Jun 23, 2026

Copy link
Copy Markdown

Release impact (release-please)

Current version 0.7.1 (on main)
After merge 0.8.0 (minor bump)

PR title: feat: deploy custom topology mcms [CLD-2766]

Merging this PR as-is will contribute a minor bump to the next release-please release PR.

Conventional commit → bump

Intent PR title prefix Bump
Bug fix fix: patch
New feature feat: minor
Breaking change feat!: / fix!: or BREAKING CHANGE: / BREAKING-CHANGE: in description major
No release chore:, docs:, ci:, refactor:, etc. none

Update the PR title before merge if you need a different bump (squash commit message = PR title).

Preview is based on this PR title only. The release-please release PR may include other unreleased commits already on main.

@ecPablo ecPablo changed the title Ecpablo/deploy topology mcms feat: deploy custom topology mcms Jun 23, 2026
@ecPablo ecPablo requested a review from Copilot June 23, 2026 19:44

This comment was marked as resolved.

ecPablo and others added 2 commits June 23, 2026 14:09
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Pablo Estrada <139084212+ecPablo@users.noreply.github.com>

This comment was marked as resolved.

ecPablo and others added 8 commits June 23, 2026 15:55
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Pablo Estrada <139084212+ecPablo@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Pablo Estrada <139084212+ecPablo@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Pablo Estrada <139084212+ecPablo@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Pablo Estrada <139084212+ecPablo@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Pablo Estrada <139084212+ecPablo@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Pablo Estrada <139084212+ecPablo@users.noreply.github.com>
@ecPablo ecPablo changed the base branch from main to ggoh/CLD-2762/transfer-to-mcms June 23, 2026 22:38
@ecPablo ecPablo requested a review from Copilot June 23, 2026 23:05
@ecPablo ecPablo changed the base branch from ggoh/CLD-2762/transfer-to-mcms to main June 23, 2026 23:05

@graham-chainlink graham-chainlink left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think my force push in my ggoh/CLD-2762/transfer-to-mcms branch stuffed up your PR here, so changes are a bit hard to see now.

Comment thread mcms/changesets/deploy-custom-topology/types.go Outdated
Base automatically changed from ggoh/CLD-2762/transfer-to-mcms to main June 24, 2026 12:22
ecPablo added 2 commits June 24, 2026 06:48
# Conflicts:
#	mcms/changesets/set-config/registry.go
Copilot AI review requested due to automatic review settings June 24, 2026 12:50

This comment was marked as resolved.

@ecPablo ecPablo requested a review from graham-chainlink June 24, 2026 14:43
@ecPablo ecPablo enabled auto-merge (squash) June 24, 2026 14:44

@graham-chainlink graham-chainlink left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me!

Comment thread mcms/changesets/deploy-custom-topology/changeset.go Outdated
Comment thread mcms/changesets/deploy-custom-topology/changeset.go Outdated
Comment thread mcms/changesets/deploy-custom-topology/changeset.go Outdated
Comment thread mcms/changesets/deploy-custom-topology/changeset.go Outdated
Comment thread mcms/changesets/deploy-custom-topology/changeset_test.go Outdated
Comment thread mcms/changesets/deploy-custom-topology/changeset.go
Comment thread mcms/evm/deploy-custom-topology/sequence_test.go
Comment on lines +257 to +258
// TestRunEVMDeployTopology_DuplicateTransferOwnership deduplicates contracts when
// TransferOwnership lists the same target more than once.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i wonder should it deduplicate or just error, sounds like an user error that the user should know?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel deduplicate is a a bit better here, as we throwing an error would only mean they have to fix something that we can automatically fix for them. I added some comments documenting the decision here 6c772fd

@graham-chainlink graham-chainlink Jun 26, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i see, i was thinking this can only be an user error and they might want to have a different address but copied the same one accidentally, it could be a mistake that needs to be rectified instead of silently ignored if that make sense? What do you think?

@cl-sonarqube-production

Copy link
Copy Markdown

@ecPablo ecPablo requested a review from graham-chainlink June 25, 2026 22:54
@ecPablo ecPablo merged commit b9638bc into main Jun 26, 2026
17 checks passed
@ecPablo ecPablo deleted the ecpablo/deploy-topology-mcms branch June 26, 2026 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants