Skip to content

feat: jd changesets#103

Merged
ChrisAmora merged 1 commit into
mainfrom
feat/jd-changesets
Jun 26, 2026
Merged

feat: jd changesets#103
ChrisAmora merged 1 commit into
mainfrom
feat/jd-changesets

Conversation

@ChrisAmora

@ChrisAmora ChrisAmora commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

feat: JD changesets and operations

Adds six changesets (and their underlying operations/sequences) for managing nodes and jobs in Job Distributor

@github-actions

Copy link
Copy Markdown

Release impact (release-please)

Current version 0.7.1 (on main)
After merge 0.8.0 (minor bump)

PR title: feat: jd changesets

Merging this PR as-is will contribute a minor bump to the next release-please release PR.

Conventional commit → bump

Intent PR title prefix Bump
Bug fix fix: patch
New feature feat: minor
Breaking change feat!: / fix!: or BREAKING CHANGE: / BREAKING-CHANGE: in description major
No release chore:, docs:, ci:, refactor:, etc. none

Update the PR title before merge if you need a different bump (squash commit message = PR title).

Preview is based on this PR title only. The release-please release PR may include other unreleased commits already on main.

@ChrisAmora ChrisAmora force-pushed the feat/jd-changesets branch 2 times, most recently from a8ce622 to eee48fa Compare June 26, 2026 01:25
@ChrisAmora ChrisAmora marked this pull request as ready for review June 26, 2026 01:44
@ChrisAmora ChrisAmora requested a review from a team as a code owner June 26, 2026 01:44
Comment thread jd/changesets/jobs.go Outdated
Comment thread jd/changesets/jobs.go Outdated
Comment thread jd/changesets/jobs.go Outdated
Comment thread jd/changesets/jobs.go Outdated
Comment thread jd/operations/nodes.go
@ChrisAmora ChrisAmora force-pushed the feat/jd-changesets branch from eee48fa to 5dcc1e3 Compare June 26, 2026 13:29

@ecPablo ecPablo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left 2 non blocking comments feel free to address them or just merge

Comment thread jd/changesets/jobs/jobs_test.go Outdated
Comment thread jd/changesets/nodes/nodes_test.go Outdated
@ChrisAmora ChrisAmora force-pushed the feat/jd-changesets branch from 5dcc1e3 to 0d2db11 Compare June 26, 2026 17:20
@cl-sonarqube-production

Copy link
Copy Markdown

Quality Gate failed Quality Gate failed

Failed conditions
37.2% Coverage on New Code (required ≥ 75%)

See analysis details on SonarQube

@ChrisAmora ChrisAmora merged commit 628cfb7 into main Jun 26, 2026
16 of 17 checks passed
@ChrisAmora ChrisAmora deleted the feat/jd-changesets branch June 26, 2026 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants