refactor(mcms): move chain-specific changeset tests to family packages#105
Conversation
Chain integration tests for deploy and firedrill lived under mcms/changesets; relocate them to mcms/evm and mcms/solana to match the transfer-to-timelock layout.
Release impact (release-please)
PR title: This title will not trigger a semver bump when squash-merged to Conventional commit → bump
Update the PR title before merge if you need a different bump (squash commit message = PR title). Preview is based on this PR title only. The release-please release PR may include other unreleased commits already on |
product-security-plaid-production
Bot
requested a review
from DimitriosNaikopoulos
There was a problem hiding this comment.
Pull request overview
Refactors MCMS chain-specific integration tests so they live alongside their respective chain-family implementations (EVM/Solana), while keeping chain-agnostic precondition tests under mcms/changesets.
Changes:
- Updated test package names to match the family package names (
evmdeploy,evmfiredrill,solfiredrill) using external test packages (*_test). - Replaced broad “register all families” blank-imports with targeted blank-imports of the specific family package and its readers (EVM/Solana) to drive init-time registration.
- Minor cleanup of an obsolete comment in the EVM deploy changeset integration test.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| mcms/solana/firedrill/changeset_test.go | Uses solfiredrill_test and blank-imports Solana firedrill + readers to ensure Solana registration for the integration test. |
| mcms/evm/firedrill/changeset_test.go | Uses evmfiredrill_test and blank-imports EVM firedrill + readers to ensure EVM registration for the integration test. |
| mcms/evm/deploy/changeset_test.go | Uses evmdeploy_test to align with the EVM deploy package and keeps the targeted blank-import registration. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Summary
mcms/changesets/deploy/changeset_evm_test.gotomcms/evm/deploy/changeset_test.gomcms/changesets/firedrill/changeset_evm_test.gotomcms/evm/firedrill/changeset_test.gomcms/changesets/firedrill/changeset_solana_test.gotomcms/solana/firedrill/changeset_test.goChain-agnostic precondition tests remain in
mcms/changesets. This aligns deploy and firedrill with the transfer-to-timelock pattern, where chain-specific integration tests live alongside their family implementations and blank-import only the relevantmcms/<family>/packages.