Skip to content

test(mcms): replace legacy changeset usage#115

Merged
graham-chainlink merged 1 commit into
mainfrom
ggoh/mcms/remove-legacy
Jul 1, 2026
Merged

test(mcms): replace legacy changeset usage#115
graham-chainlink merged 1 commit into
mainfrom
ggoh/mcms/remove-legacy

Conversation

@graham-chainlink

Copy link
Copy Markdown
Collaborator

In the new changesets under mcms, we should be using the new changesets instead of the legacy changesets

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates MCMS integration/unit tests to stop relying on legacy/mcms/changesets and instead use the newer mcms/changesets/* implementations, aligning test coverage with the migrated changeset APIs and datastore-based address resolution.

Changes:

  • Replace legacy DeployMCMSWithTimelockV2 usage in Solana/EVM tests with mcms/changesets/deploy.
  • Replace legacy transfer-to-timelock flows with mcms/changesets/transfer-to-timelock and refkey-based contract selection.
  • Update Solana test runtimes to seed a datastore (program IDs) via solanatest.NewDataStoreWithMCMSPrograms rather than using an AddressBook.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
mcms/solana/grant-role/sequence_test.go Switches runtime setup and transfer-to-timelock flow to new deploy + transfer changesets and datastore-based state loading.
mcms/solana/firedrill/changeset_test.go Migrates Solana firedrill test runtime bootstrap to new deploy changeset + seeded datastore.
mcms/solana/changesets/fund-mcm-pdas/changeset_test.go Removes legacy AddressBook wiring from test runtime creation (tests explicitly set datastore on the environment).
mcms/evm/set-config/sequence_test.go Removes legacy-based helpers, keeping focused unit tests for ref resolution / error paths.
mcms/evm/set-config/operation_test.go Moves operation tests to an external test package and updates to new deploy-based runtime setup.
mcms/evm/set-config/changeset_test.go Migrates deploy + transfer-to-timelock setup and updates state/address access patterns to use ref resolution.
mcms/evm/grant-role/sequence_test.go Switches EVM grant-role runtime bootstrap to the new deploy changeset.
mcms/evm/firedrill/changeset_test.go Switches EVM firedrill runtime bootstrap to the new deploy changeset.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@graham-chainlink graham-chainlink force-pushed the ggoh/mcms/remove-legacy branch from 161e2cd to 1e5bc0a Compare July 1, 2026 06:31

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests moved from sequence_test.go to here and changing it so it covers changeset level (integration test)

Base automatically changed from ggoh/cld2762/solana-transfer-timelock to main July 1, 2026 13:34
@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

Release impact (release-please)

Current version 0.7.1 (on main)
After merge no version bump (no release)

PR title: test(mcms): replace legacy changeset usage

This title will not trigger a semver bump when squash-merged to main. Use feat: for a minor release, or fix: / perf: / revert: for a patch release.

Conventional commit → bump

Intent PR title prefix Bump
Bug fix fix: patch
New feature feat: minor
Breaking change feat!: / fix!: or BREAKING CHANGE: / BREAKING-CHANGE: in description major
No release chore:, docs:, ci:, refactor:, etc. none

Update the PR title before merge if you need a different bump (squash commit message = PR title).

Preview is based on this PR title only. The release-please release PR may include other unreleased commits already on main.

@graham-chainlink graham-chainlink force-pushed the ggoh/mcms/remove-legacy branch from 1e5bc0a to c43a861 Compare July 1, 2026 13:42
@graham-chainlink graham-chainlink marked this pull request as ready for review July 1, 2026 13:42
@graham-chainlink graham-chainlink requested a review from a team as a code owner July 1, 2026 13:42
Copilot AI review requested due to automatic review settings July 1, 2026 13:42

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Comment thread mcms/solana/grant-role/changeset_test.go
Comment thread mcms/evm/grant-role/sequence_test.go Outdated
In the new changesets under mcms, we should be using the new changesets instead of the legacy changesets
@cl-sonarqube-production

Copy link
Copy Markdown

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Comment thread mcms/evm/set-config/changeset_test.go
@graham-chainlink graham-chainlink requested a review from ecPablo July 1, 2026 14:01
@graham-chainlink graham-chainlink merged commit 3e32e1d into main Jul 1, 2026
18 checks passed
@graham-chainlink graham-chainlink deleted the ggoh/mcms/remove-legacy branch July 1, 2026 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants